Skip to content

FINERACT-2326: Fix configuration options for CORS #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IOhacker merged 1 commit into from
Dec 9, 2025
Merged

FINERACT-2326: Fix configuration options for CORS #5210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...core/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ public static class ExecuteCommandProperties {
public static class CorsProperties {

private boolean enabled;
private List<String> allowedOrigins;
private List<String> allowedOriginPatterns;
private List<String> allowedMethods;
private List<String> allowedHeaders;
private List<String> exposedHeaders;
Expand Down
2 changes: 1 addition & 1 deletion ...provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public AuthenticationManager authenticationManagerBean() throws Exception {
public CorsConfigurationSource corsConfigurationSource() {
CorsConfiguration config = new CorsConfiguration();
FineractProperties.CorsProperties corsConfiguration = fineractProperties.getSecurity().getCors();
config.setAllowedOrigins(corsConfiguration.getAllowedOrigins());
config.setAllowedOriginPatterns(corsConfiguration.getAllowedOriginPatterns());
config.setAllowedMethods(corsConfiguration.getAllowedMethods());
config.setAllowedHeaders(corsConfiguration.getAllowedHeaders());
config.setExposedHeaders(corsConfiguration.getExposedHeaders());
Expand Down
2 changes: 1 addition & 1 deletion ...in/java/org/apache/fineract/infrastructure/security/config/AuthorizationServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public SecurityFilterChain protectedEndpoints(HttpSecurity http) throws Exceptio
public CorsConfigurationSource corsConfigurationSource() {
CorsConfiguration config = new CorsConfiguration();
FineractProperties.CorsProperties corsConfiguration = fineractProperties.getSecurity().getCors();
config.setAllowedOrigins(corsConfiguration.getAllowedOrigins());
config.setAllowedOriginPatterns(corsConfiguration.getAllowedOriginPatterns());
config.setAllowedMethods(corsConfiguration.getAllowedMethods());
config.setAllowedHeaders(corsConfiguration.getAllowedHeaders());
config.setExposedHeaders(corsConfiguration.getExposedHeaders());
Expand Down
8 changes: 4 additions & 4 deletions fineract-provider/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ fineract.security.hsts.enabled=${FINERACT_SECURITY_HSTS_ENABLED:false}

#CORS configuration
fineract.security.cors.enabled=${FINERACT_SECURITY_CORS_ENABLED:true}
fineract.security.cors.allowed-origins=${FINERACT_SECURITY_CORS_ALLOWED_ORIGINS:"*"}
fineract.security.cors.allowed-methods=${FINERACT_SECURITY_CORS_ALLOWED_METHODS:"*"}
fineract.security.cors.allowed-headers=${FINERACT_SECURITY_CORS_ALLOWED_HEADERS:"*"}
fineract.security.cors.exposed-headers=${FINERACT_SECURITY_CORS_EXPOSED_HEADERS:"*"}
fineract.security.cors.allowed-origin-patterns=${FINERACT_SECURITY_CORS_ALLOWED_ORIGIN_PATTERNS:*}
fineract.security.cors.allowed-methods=${FINERACT_SECURITY_CORS_ALLOWED_METHODS:*}
fineract.security.cors.allowed-headers=${FINERACT_SECURITY_CORS_ALLOWED_HEADERS:*}
fineract.security.cors.exposed-headers=${FINERACT_SECURITY_CORS_EXPOSED_HEADERS:*}
fineract.security.cors.allow-credentials=${FINERACT_SECURITY_CORS_ALLOW_CREDENTIALS:true}

# EXAMPLE: OAuth2 client configuration (frontend-client)
Expand Down
8 changes: 4 additions & 4 deletions fineract-provider/src/test/resources/application-test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ fineract.security.hsts.enabled=false

#CORS configuration
fineract.security.cors.enabled=true
fineract.security.cors.allowed-origins="*"
fineract.security.cors.allowed-methods="*"
fineract.security.cors.allowed-headers="*"
fineract.security.cors.exposed-headers="*"
fineract.security.cors.allowed-origin-patterns=*
fineract.security.cors.allowed-methods=*
fineract.security.cors.allowed-headers=*
fineract.security.cors.exposed-headers=*
fineract.security.cors.allow-credentials=true

fineract.tenant.host=localhost
Expand Down
Loading