-
Notifications
You must be signed in to change notification settings - Fork 2.3k
FINERACT-2048: Make amount/recurrence fields optional for DUES standing instruction type #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Monica-CodingWorld
wants to merge
2
commits into
apache:develop
Choose a base branch
from
Monica-CodingWorld:fix-FINERACT-2048
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−18
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
...java/org/apache/fineract/portfolio/account/data/StandingInstructionDataValidatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.portfolio.account.data; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import org.apache.fineract.portfolio.account.domain.StandingInstructionType; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class StandingInstructionDataValidatorTest { | ||
|
|
||
| @Test | ||
| void isAmountRequired_fixedAmountTransferType_returnsTrue() { | ||
| assertTrue(isAmountRequired(1)); | ||
| } | ||
|
|
||
| @Test | ||
| void isAmountRequired_duesType_returnsFalse() { | ||
| assertFalse(isAmountRequired(2)); | ||
| } | ||
|
|
||
| @Test | ||
| void isAmountRequired_nullType_returnsFalse() { | ||
| assertFalse(isAmountRequired(null)); | ||
| } | ||
|
|
||
| @Test | ||
| void isRecurrenceRequired_fixedAmountTransferType_returnsTrue() { | ||
| assertTrue(isRecurrenceRequired(1)); | ||
| } | ||
|
|
||
| @Test | ||
| void isRecurrenceRequired_duesType_returnsFalse() { | ||
| assertFalse(isRecurrenceRequired(2)); | ||
| } | ||
|
|
||
| @Test | ||
| void isRecurrenceRequired_nullType_returnsTrue() { | ||
| assertTrue(isRecurrenceRequired(null)); | ||
| } | ||
|
|
||
| @Test | ||
| void standingInstructionType_fixedAmountTransfer_isFixedAmountTransfer() { | ||
| StandingInstructionType type = StandingInstructionType.fromInt(1); | ||
| assertTrue(type.isFixedAmoutTransfer()); | ||
| assertFalse(type.isDuesAmoutTransfer()); | ||
| } | ||
|
|
||
| @Test | ||
| void standingInstructionType_dues_isDuesAmountTransfer() { | ||
| StandingInstructionType type = StandingInstructionType.fromInt(2); | ||
| assertTrue(type.isDuesAmoutTransfer()); | ||
| assertFalse(type.isFixedAmoutTransfer()); | ||
| } | ||
|
|
||
| private boolean isAmountRequired(Integer standingInstructionType) { | ||
| return standingInstructionType != null && StandingInstructionType.fromInt(standingInstructionType).isFixedAmoutTransfer(); | ||
| } | ||
|
|
||
| private boolean isRecurrenceRequired(Integer standingInstructionType) { | ||
| return standingInstructionType == null || !StandingInstructionType.fromInt(standingInstructionType).isDuesAmoutTransfer(); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little bit complicated. and if conditions can be merged, also of there is any business rule that is implemented make sure to document that helper function
Business rules should be explicit and self-documenting
while the Github Action is not run here is a pro tip you can run the check on your forked repo and add testcase for more coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aman-Mittal Thank you so much for your guidance and suggestions. I will improve the PR and update shortly.