48-interval-schema #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EandrewJones
requested changes
Jul 15, 2024
There was a problem hiding this comment.
I don't see a good reason to split the UserALE schemas into three separate files. They're closely coupled (developers are likely to need to bounce back and forth between the files when working on the userale schema; therefore keeping in the same file simplifies cognitive load) and it repeats lots of imports.
A few other nits. Almost there.
EandrewJones
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a polymorphic type
UserAleSchemathat is auto-evaluated to either a UserAle raw log or a UserAle interval log upon validation. This change introduces some problems with serialization, namely the order of fields is not preserved anymore compared to the original log. This is due to the specific raw and interval logs inheriting from a baseUserAleBaseclass that contains the shared fields. When serialized, theUserAleBasefields appear first followed by the fields exclusive to the specific log. There appears to be no native way to fix this in Pydantic at the moment. This PR will probably require some discussion and changes.Closes #48