Sessions #412
Merged
Sessions #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jyyjy
commented
Feb 13, 2024
Jyyjy
commented
- Git ignores the build. It makes PR's harder, and the build can still be included in release tags as artifacts.
- Adds httpSessionId and browserSessionID.
- Http session is essentially the same as sessionId, but is crypto-graphically unique.
- sessionId is left as is for users to set the application specific session id. In a 3.0.0 release, we can rename sessionId to serverSessionId and set the default to null. Or remove it entirely and allow users to set it as a custom field.
- browserSessionID is null be default unless using the web ext.
- The background script attempts to remap the session id's of tab events so they match the target tab's events. However some tab events happen before userale is initialized (e.g. tabs.onCreated). I'm sure there's a clever solution, but I'll leave that as a future issue.
EandrewJones
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Alright, I am following this code.
Nonetheless, I'm ripping off the band-aid. It's time to add Doc strings top each function.
| updateConfig(res); | ||
| browserSessionId = JSON.parse(window.sessionStorage.getItem('userAleHttpSessionId')); |
There was a problem hiding this comment.
Is this the only place where the browserSessionId is set?
Why does this come from userAleHTTPSessionId?
There was a problem hiding this comment.
Yes it is the only place, and it comes from userAleHTTPSessionId because browser session is equivalent to the http session of the background page.
EandrewJones
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.