Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

399 Fixed bug 'AuthHeaders ignored for sendOnClose' #453

Merged
merged 1 commit into from
Jun 5, 2024
Merged

399 Fixed bug 'AuthHeaders ignored for sendOnClose' #453

merged 1 commit into from
Jun 5, 2024

Conversation

rc10house
Copy link
Contributor

#399 Changed sendOnClose() to use global.fetch() instead of global.navigator.sendBeacon . (Recreating this PR in a cleaner fashion)

@rc10house rc10house changed the title Fixed bug 'AuthHeaders ignored for sendOnClose' 399 Fixed bug 'AuthHeaders ignored for sendOnClose' May 9, 2024
@EandrewJones EandrewJones self-requested a review May 9, 2024 23:05
EandrewJones
EandrewJones requested changes May 9, 2024
View reviewed changes
src/sendLogs.js Outdated Show resolved Hide resolved
@rc10house rc10house force-pushed the 399-auth_headers_sendOnClose_bug branch from c1d96c5 to bcd16ec Compare May 14, 2024 01:21
@rc10house rc10house requested a review from EandrewJones May 14, 2024 01:21
EandrewJones
EandrewJones requested changes May 14, 2024
View reviewed changes
test/sendLogs_spec.js Outdated Show resolved Hide resolved
@rc10house rc10house force-pushed the 399-auth_headers_sendOnClose_bug branch from bcd16ec to 68543a7 Compare June 3, 2024 23:34
@rc10house rc10house requested a review from EandrewJones June 3, 2024 23:34
@rc10house
Copy link
Contributor Author

@EandrewJones @Jyyjy Resolved bug with sendOnClose() by switching to fetch(), had to mock fetch in a different way inside the test file because Node doesn't have fetch() when running Jest.

EandrewJones
EandrewJones requested changes Jun 4, 2024
View reviewed changes
src/sendLogs.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@rc10house rc10house force-pushed the 399-auth_headers_sendOnClose_bug branch from 68543a7 to 8fcbf85 Compare June 4, 2024 14:19
@rc10house rc10house requested a review from EandrewJones June 4, 2024 14:20
@rc10house rc10house closed this Jun 5, 2024
@rc10house rc10house reopened this Jun 5, 2024
@EandrewJones EandrewJones merged commit 86189d8 into apache:master Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EandrewJones EandrewJones EandrewJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rc10house @EandrewJones