fix: extract magic number into a named constant

Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
apache · Sep 30, 2024 · 0b5a57d · 0b5a57d
1 parent fd469c2
commit 0b5a57d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...ector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/utils/MySqlTypeUtils.java b/...ector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/utils/MySqlTypeUtils.java
@@ -107,6 +107,7 @@ public class MySqlTypeUtils {
  private static final String MULTIPOLYGON = "MULTIPOLYGON";
  private static final String MULTILINESTRING = "MULTILINESTRING";
  private static final String UNKNOWN = "UNKNOWN";
+ private static final int FLOAT_LENGTH_UNSPECIFIED_FLAG = -1;
 
  /** Returns a corresponding Flink data type from a debezium {@link Column}. */
  public static DataType fromDbzColumn(Column column) {
@@ -164,7 +165,7 @@ private static DataType convertFromColumn(Column column) {
  case FLOAT:
  case FLOAT_UNSIGNED:
  case FLOAT_UNSIGNED_ZEROFILL:
- if (column.length() != -1) {
+ if (column.length() != FLOAT_LENGTH_UNSPECIFIED_FLAG) {
  // For FLOAT types with length provided explicitly, treat it like DOUBLE
  return DataTypes.DOUBLE();
  } else {