Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql connector support parallel snapshot when there are no primary key for tables #1827

Closed
EMsnap opened this issue Dec 13, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@EMsnap
Copy link
Contributor

EMsnap commented Dec 13, 2022

Is your feature request related to a problem? Please describe.

Mysql connector now only support parallel snapshot for tables with primary key which means that
we can only use cdc-version1 to support multiple tables read when there are some tables are without primary key
Read multiple tables using just one subtask is pretty slow and unbearable for the users

Describe the solution you'd like

1、remove the constraint in mysql-cdc 2.0 for primary key
2、for those tables which don't contain primary key, split the whole table as a chunk during split stage
3、since there's no need for the SnapshotSplitReader to upsert binlog with the snapshot data for a whole table
split , just let the highwatermark equals to the lowwatermark to escape the upsert stage.

@EMsnap EMsnap added the enhancement New feature or request label Dec 13, 2022
@leonardBang leonardBang added this to the V2.4.0 milestone Dec 13, 2022
EMsnap pushed a commit to EMsnap/flink-cdc-connectors that referenced this issue Dec 14, 2022
@zstraw
Copy link

zstraw commented Mar 22, 2023

@EMsnap Hi, EMsnap, what's the status of the issue? I find the PR only modify the codes in test.

@zstraw
Copy link

zstraw commented Mar 27, 2023

Hi, @leonardBang , could you spare some time to review the PR?

ruanhang1993 added a commit to ruanhang1993/flink-cdc-connectors that referenced this issue May 22, 2023
Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
ruanhang1993 added a commit to ruanhang1993/flink-cdc-connectors that referenced this issue May 29, 2023
Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
ruanhang1993 added a commit to ruanhang1993/flink-cdc-connectors that referenced this issue May 29, 2023
Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
@ruanhang1993 ruanhang1993 assigned ruanhang1993 and unassigned EMsnap May 30, 2023
@ruanhang1993
Copy link
Contributor

Closed by #2150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants