Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdc-base]remove redundant source metrics register #2403

Closed
2 tasks done
loserwang1024 opened this issue Aug 17, 2023 · 1 comment
Closed
2 tasks done

[cdc-base]remove redundant source metrics register #2403

loserwang1024 opened this issue Aug 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@loserwang1024
Copy link
Contributor

loserwang1024 commented Aug 17, 2023 •
edited
Loading

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Since FLIP-179: Expose Standardized Operator Metrics and Flink 1.14 version, some metrics have already been registered or counted in Flink Source Operator, so no need to do again in Flink CDC's SourceReader:

  • currentEmitEventTimeLag and sourceIdleTime don't need to register or count in Flink CDC's SourceReader.
  • numRecordsInErrors just count in in Flink CDC's SourceReader, but don't need to register here. Get corresponding Counter from SourceReaderMetricGroup#getNumRecordsInErrorsCounter()

Besides that, current metrics pendingRecords doesn't count anywhere, why not remove it.

If apply this issue, Flink Cdc 2.5 doesn't support Clink 1.13 anymore

Anything else?

Current numRecordsIn also has some problems in Flink.
Flink community will solve this later in FLINK-30234

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@loserwang1024 loserwang1024 added the enhancement New feature or request label Aug 17, 2023
@loserwang1024
Copy link
Contributor Author

CC, @ruanhang1993 @leonardBang , WDYT?

loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Aug 18, 2023
@loserwang1024
[cdc-base] Remove redundant source metrics register(apache#2403)
68ff248
loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Aug 21, 2023
@loserwang1024
[cdc-base]remove redundant source metrics register(apache#2403)
3d264e9
loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Aug 21, 2023
@loserwang1024
[cdc-base]remove support for flink 1.13(apache#2403)
34ff3c9
loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Aug 21, 2023
@loserwang1024
[cdc-base]remove redundant source metrics register(apache#2403)
42b9970
loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Aug 21, 2023
@loserwang1024
[cdc-base]remove support for flink 1.13(apache#2403)
43de5ff
@loserwang1024 loserwang1024 mentioned this issue Aug 21, 2023
Merged
PatrickRen pushed a commit that referenced this issue Sep 27, 2023
@loserwang1024 @PatrickRen
[cdc-base]remove redundant source metrics register(#2403)
ad927b7
loserwang1024 added a commit to loserwang1024/flink-cdc-connectors that referenced this issue Oct 8, 2023
@loserwang1024
[cdc-base]remove support for flink 1.13(apache#2403)
bad05c8
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this issue Oct 18, 2023
@loserwang1024 @e-mhui
[cdc-base]remove redundant source metrics register(apache#2403)
1c927d3
@zhourui999 zhourui999 mentioned this issue Aug 23, 2024
Closed
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this issue Jan 13, 2025
@loserwang1024
[cdc-base]remove redundant source metrics register(apache#2403)
464aa2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loserwang1024