Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ob zh docs #1721

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

leonardBang
Copy link
Contributor

No description provided.

@gtk96
Copy link
Contributor

gtk96 commented Nov 9, 2022

https://github.com/ververica/flink-cdc-connectors/blob/release-2.3/docs/content/connectors/oceanbase-cdc.md
The number of lines in the corresponding document does not match

@leonardBang
Copy link
Contributor Author

https://github.com/ververica/flink-cdc-connectors/blob/release-2.3/docs/content/connectors/oceanbase-cdc.md The number of lines in the corresponding document does not match

Hi, @RookieGao number of lines? I did not catch your meaning

@gtk96
Copy link
Contributor

gtk96 commented Nov 9, 2022

https://github.com/ververica/flink-cdc-connectors/blob/release-2.3/docs/content/connectors/oceanbase-cdc.md The number of lines in the corresponding document does not match

Hi, @RookieGao number of lines? I did not catch your meaning

image

image

>
> 下载链接仅适用于稳定发行版本。

`flink-sql-connector-oceanbase-cdc-XXX-SNAPSHOT` 快照版本与开发分支的版本对应。要使用快照版本,您必须自行下载并编译源代码。推荐使用稳定发行版本,例如 `flink-sql-connector-oceanbase-cdc-2.3.0.jar`。您可以在 Maven 中央仓库中找到使用稳定发行版本。
Copy link
Contributor

@gtk96 gtk96 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意: flink-sql-connector-oceanbase-cdc-XXX-SNAPSHOT 版本是开发分支release-XXX对应的快照版本,快照版本用户需要下载源代码并编译相应的 jar。用户应使用已经发布的版本,例如 flink-sql-connector-oceanbase-cdc-2.3.0.jar 当前已发布的所有版本都可以在 Maven 中央仓库获取。

The translation is consistent with this passage


当启动模式不是 `INITIAL` 时,连接器无法获得一个列的精度和比例。为兼容不同的启动模式,连接器不会将一个不同精度的 OceanBase 类型映射到不同的FLink 类型。例如,`BOOLEAN`、`TINYINT(1)` 或 `BIT(1)` 均可以转换成 `BOOLEAN`。在 OceanBase 数据库中,`BOOLEAN` 等同于 `TINYINT(1)`,所以 `BOOLEAN` 和 `TINYINT` 类型的列在 Flink 中会被映射为 `TINYINT`,而 `BIT(1)` 在 Flink 中会被映射为 `BINARY(1)`。

OceanBase 数据类型 | Flink SQL 类型 | 描述
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code of the data type seems different from that of the English document?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文文档添加了 OceanBase 数据类型的跳转链接

展示效果:
image

源代码:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文文档添加了 OceanBase 数据类型的跳转链接

展示效果: image

源代码: image

Have we added this ? I don't think so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该处修改被整合到了 #1719 ,另外 2.3 的所有连接器文档都做出了修改。

参照:
https://ververica.github.io/flink-cdc-connectors/release-2.3/content/connectors/oceanbase-cdc.html#data-type-mapping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this in #1719

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leonardBang leonardBang merged commit b56a051 into apache:release-2.3 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants