Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] Fix backward compatibility on deserializing binlog offset from old versions #1758

Merged

Conversation

PatrickRen
Copy link
Contributor

This pull request fixes a backward compatibility issue on deserializing binlog offset from old versions (#1757), and add a new test for guarding the compatibility.

PatrickRen added a commit to PatrickRen/flink-cdc that referenced this pull request Nov 17, 2022
@PatrickRen PatrickRen force-pushed the fix-binlog-offset-backward-compatibility branch from eb1cbd4 to e654159 Compare November 17, 2022 13:39
@PatrickRen PatrickRen force-pushed the fix-binlog-offset-backward-compatibility branch from e654159 to 7f41a13 Compare November 18, 2022 04:14
@leonardBang leonardBang self-requested a review November 21, 2022 02:44
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRen for the fix, LGTM

@leonardBang leonardBang merged commit 70f6ad3 into apache:master Nov 21, 2022
@leonardBang
Copy link
Contributor

@PatrickRen Could you backport this PR to release-2.3 ?

leonardBang pushed a commit that referenced this pull request Nov 21, 2022
@leonardBang
Copy link
Contributor

@PatrickRen I've backborted, FYI

@ldwnt
Copy link

ldwnt commented Dec 8, 2022

@PatrickRen I applied this fix but got another exception in job manager: #1795 (comment), would you mind take a look? Thanks.

ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants