-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] update option names #2212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@senlizishi Thanks for contribution. It is reasonable. 2.4.0 version will not add new issue. |
@senlizishi Would you please rebase the branch master and make the CI pass? Thanks. |
ruanhang1993
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
2 tasks
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
…xx = database, schema or table) (apache#2212) (cherry picked from commit ba5fcbc)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
…xx = database, schema or table) (apache#2212) (cherry picked from commit ba5fcbc)
zhongqishang
pushed a commit
to zhongqishang/flink-cdc
that referenced
this pull request
Dec 7, 2023
…xx = database, schema or table) (apache#2212) (cherry picked from commit ba5fcbc)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…xx = database, schema or table) (apache#2212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the following information
I think we need update option names as below: