Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix sqlserver monitor same table in other database #2335

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[hotfix] Fix sqlserver monitor same table in other database #2335

merged 2 commits into from
Jul 21, 2023
+45 −3

Conversation

GOODBOY008
Copy link
Member

@GOODBOY008 GOODBOY008 commented Jul 21, 2023 •
edited
Loading

Fix issue #2333 .

@GOODBOY008 GOODBOY008 requested a review from ruanhang1993 July 21, 2023 03:49
ruanhang1993
ruanhang1993 reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 Thanks. Please add a test to cover this situation.

@GOODBOY008 GOODBOY008 requested a review from ruanhang1993 July 21, 2023 05:30
ruanhang1993
ruanhang1993 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GOODBOY008 GOODBOY008 merged commit 823f5a1 into apache:release-2.4 Jul 21, 2023
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
@GOODBOY008 @zhongqishang
[hotfix] Fix sqlserver monitor same table in other database (apache#2335
a059c6d 
)

* [hotfix] Fix sqlserver monitor same table in other database

* Add unit test

---------

Co-authored-by: gongzhongqiang <gongzhongqiang@gigacloudtech.com>
@GOODBOY008 GOODBOY008 deleted the release-2.4-hotfix branch January 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanhang1993 ruanhang1993

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GOODBOY008 @ruanhang1993