Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][docs] Fix the abnormal display of pictures #2513

Merged
merged 5 commits into from
Sep 22, 2023
Merged

[hotfix][docs] Fix the abnormal display of pictures #2513

merged 5 commits into from
Sep 22, 2023

Conversation

gtk96
Copy link
Contributor

@gtk96 gtk96 commented Sep 21, 2023

fix @lvyanquan the mentioned pictures show abnormality.

@gtk96
Copy link
Contributor Author

gtk96 commented Sep 21, 2023

@lvyanquan @Jiabao-Sun PTAL

@lvyanquan
Copy link
Contributor

lvyanquan commented Sep 21, 2023 •
edited
Loading

It works.
What's more, you may need to add three spaces before your bash code and picture to avoid reordering sequence numbers.

截屏2023-09-21 上午11 31 25

lvyanquan
lvyanquan reviewed Sep 21, 2023
View reviewed changes
docs/content/about.md Outdated Show resolved Hide resolved
@gtk96 gtk96 requested a review from lvyanquan September 22, 2023 01:03
@gtk96
Copy link
Contributor Author

gtk96 commented Sep 22, 2023

@Jiabao-Sun @GOODBOY008 PTAL

@lvyanquan
Copy link
Contributor

Sorry for bother you again OwO. after test, find that these lines in 3,4,5 in bash should also add spaces.

git clone https://github.com/your_name/flink-cdc-connectors.git
cd flink-cdc-connectors
mvn clean install -DskipTests

@gtk96 gtk96 requested a review from lvyanquan September 22, 2023 01:51
@lvyanquan
Copy link
Contributor

lvyanquan commented Sep 22, 2023 •
edited
Loading

LGTM, Thanks for your patience.

Jiabao-Sun
Jiabao-Sun approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gtk96 for the great work.
LGTM

@Jiabao-Sun Jiabao-Sun merged commit c896df8 into apache:master Sep 22, 2023
@Jiabao-Sun
Copy link
Contributor

Thanks @lvyanquan for the helpful review.

@gtk96 gtk96 deleted the patch-1 branch September 22, 2023 02:50
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Oct 18, 2023
@gtk96 @e-mhui
[hotfix][docs] Fix the abnormal display of pictures (apache#2513)
dc2ac2d
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@gtk96
[hotfix][docs] Fix the abnormal display of pictures (apache#2513)
43c49b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiabao-Sun Jiabao-Sun Jiabao-Sun approved these changes

@lvyanquan lvyanquan lvyanquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtk96 @lvyanquan @Jiabao-Sun