Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pom] Use ${revision} replace specific version. #2623

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

joyCurry30
Copy link
Contributor

As we use specific version like "3.0-SNAPSHOT", we need to repeat modifications between different modules. So why not use a placeholder like ${revision}.

Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 'revision' property is used, we should also add the flatten-maven-plugin, refer to https://maven.apache.org/maven-ci-friendly.html#install-deploy

@joyCurry30
Copy link
Contributor Author

@whhe I add the flatten-maven-plugin. cc plz.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait for ci to pass.

@whhe whhe merged commit d01f0a9 into apache:master Nov 6, 2023
@leonardBang
Copy link
Contributor

Thanks @joyCurry30 and @whhe for the contribution and review, I've one minor question: What's the meaning revision? could we use maven default properties ${project.version} in this case ?

@whhe
Copy link
Member

whhe commented Nov 7, 2023

Thanks @joyCurry30 and @whhe for the contribution and review, I've one minor question: What's the meaning revision? could we use maven default properties ${project.version} in this case ?

As we need to declare ${project.version} explicitly in each pom file (the parent part), we need a new property to set a original value for it, and revision is a common option to be used here.

@leonardBang
Copy link
Contributor

Thanks @whhe for the explanation, got it.

ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants