-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pom] Use ${revision} replace specific version. #2623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 'revision' property is used, we should also add the flatten-maven-plugin
, refer to https://maven.apache.org/maven-ci-friendly.html#install-deploy
161a7ba
to
d59b1ab
Compare
@whhe I add the flatten-maven-plugin. cc plz. |
d59b1ab
to
f818ffa
Compare
f818ffa
to
e409da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wait for ci to pass.
Thanks @joyCurry30 and @whhe for the contribution and review, I've one minor question: What's the meaning |
As we need to declare |
Thanks @whhe for the explanation, got it. |
As we use specific version like "3.0-SNAPSHOT", we need to repeat modifications between different modules. So why not use a placeholder like ${revision}.