Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent. #2677

Merged

Conversation

joyCurry30
Copy link
Contributor

Refer to #2665
Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.
PTAL. @lvyanquan @GOODBOY008

@joyCurry30 joyCurry30 force-pushed the 2665_add_implementation_datachange_event branch from d06a4ab to e449112 Compare November 9, 2023 13:57
@joyCurry30 joyCurry30 force-pushed the 2665_add_implementation_datachange_event branch from e449112 to f943ec8 Compare November 9, 2023 13:59
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contritbutions, I left a minor comment.

Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GOODBOY008 GOODBOY008 merged commit de45676 into apache:master Nov 9, 2023
@joyCurry30 joyCurry30 deleted the 2665_add_implementation_datachange_event branch November 10, 2023 02:01
lvyanquan pushed a commit to lvyanquan0624/flink-cdc-connectors that referenced this pull request Nov 10, 2023
… add implementation for DataChangeEvent. (apache#2677)

* [3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.

* [3.0][cdc-common] Remove @param for code cleaning.

* [3.0][cdc-common] Make the DataChangeEvent constructor private.
lvyanquan pushed a commit to lvyanquan0624/flink-cdc-connectors that referenced this pull request Nov 10, 2023
… add implementation for DataChangeEvent. (apache#2677)

* [3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.

* [3.0][cdc-common] Remove @param for code cleaning.

* [3.0][cdc-common] Make the DataChangeEvent constructor private.
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
… add implementation for DataChangeEvent. (apache#2677)

* [3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.

* [3.0][cdc-common] Remove @param for code cleaning.

* [3.0][cdc-common] Make the DataChangeEvent constructor private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants