Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle][doc] Fix oracle quick start #2727

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

GOODBOY008
Copy link
Member

No description provided.

@GOODBOY008
Copy link
Member Author

@YesOrNo828 PTAL

Copy link
Contributor

@YesOrNo828 YesOrNo828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 I tested local env, but met this exception:

java.lang.IllegalArgumentException: Unable to convert to TimestampData from unexpected value '1596103702001' of type java.lang.Long
   at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$2.convert(OracleDeserializationConverterFactory.java:96)
   at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$3.convert(OracleDeserializationConverterFactory.java:117)
   at com.ververica.cdc.debezium.table.RowDataDebeziumDeserializeSchema$17.convert(RowDataDebeziumDeserializeSchema.java:653)

I think we should change the Flink SQL DDL of table: orders.ORDER_DATE and enriched_orders.ORDER_DATE type to TIMESTAMP(3). And the quickstart would run successfully.

@GOODBOY008
Copy link
Member Author

@YesOrNo828 Thank you for your careful check, I had modify code which you said.

Copy link
Contributor

@YesOrNo828 YesOrNo828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008
Copy link
Member Author

@leonardBang PTAL , Maybe back support to 2.4.x.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for the contribution and @YesOrNo828 for the review, LGTM.
feel free to merge and backport to release-2.4 branch.

@leonardBang leonardBang merged commit 9aed54d into apache:master Nov 24, 2023
@leonardBang leonardBang added this to the V3.0.0 milestone Nov 24, 2023
GOODBOY008 added a commit to GOODBOY008/flink-cdc that referenced this pull request Nov 25, 2023
GOODBOY008 added a commit that referenced this pull request Nov 25, 2023
@GOODBOY008 GOODBOY008 deleted the master-oracle-doc branch November 25, 2023 06:26
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Dec 2, 2023
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants