-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oracle][doc] Fix oracle quick start #2727
Conversation
@YesOrNo828 PTAL |
752a119
to
003e88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GOODBOY008 I tested local env, but met this exception:
java.lang.IllegalArgumentException: Unable to convert to TimestampData from unexpected value '1596103702001' of type java.lang.Long
at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$2.convert(OracleDeserializationConverterFactory.java:96)
at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$3.convert(OracleDeserializationConverterFactory.java:117)
at com.ververica.cdc.debezium.table.RowDataDebeziumDeserializeSchema$17.convert(RowDataDebeziumDeserializeSchema.java:653)
I think we should change the Flink SQL DDL of table: orders.ORDER_DATE and enriched_orders.ORDER_DATE type to TIMESTAMP(3). And the quickstart would run successfully.
@YesOrNo828 Thank you for your careful check, I had modify code which you said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@leonardBang PTAL , Maybe back support to 2.4.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for the contribution and @YesOrNo828 for the review, LGTM.
feel free to merge and backport to release-2.4
branch.
This closes apache#2727. (cherry picked from commit 9aed54d)
This closes apache#2727. (cherry picked from commit 9aed54d)
No description provided.