[cdc-pipeline-connector] add MULTI_SPLITS_SINGLE_TABLE to provide multiple splits case of ValuesDataSourceHelper. #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvyanquan
force-pushed
the
SourceEventHelper
branch
3 times, most recently
from
004757f to
58fa71c
Compare
leonardBang
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Thanks @lvyanquan for the contribution, could you add some basic test for new introduced cases
lvyanquan
force-pushed
the
SourceEventHelper
branch
2 times, most recently
from
285e25e to
c15dd84
Compare
A test for MULTI_SPLITS_SINGLE_TABLE was added and modify ValuesDataSource to support switching from snapshot stage to incremental stage. |
lvyanquan
force-pushed
the
SourceEventHelper
branch
2 times, most recently
from
4afcb8c to
95e49dd
Compare
leonardBang
reviewed
Nov 25, 2023
There was a problem hiding this comment.
Thanks @lvyanquan for the contribution, I left some comments
...ues/src/test/java/com/ververica/cdc/connectors/values/source/ValuesDataSourceHelperTest.java
Outdated
Show resolved
Hide resolved
...nector-values/src/main/java/com/ververica/cdc/connectors/values/source/ValuesDataSource.java
Outdated
Show resolved
Hide resolved
...nector-values/src/main/java/com/ververica/cdc/connectors/values/source/ValuesDataSource.java
Outdated
Show resolved
Hide resolved
...nector-values/src/main/java/com/ververica/cdc/connectors/values/source/ValuesDataSource.java
Outdated
Show resolved
Hide resolved
lvyanquan
force-pushed
the
SourceEventHelper
branch
from
6b6cf91 to
84677e3
Compare
|
Address it. |
leonardBang
reviewed
Nov 26, 2023
...values/src/main/java/com/ververica/cdc/connectors/values/source/ValuesDataSourceOptions.java
Outdated
Show resolved
Hide resolved
lvyanquan
force-pushed
the
SourceEventHelper
branch
3 times, most recently
from
45bc68c to
f64f9f9
Compare
|
@lvyanquan A rebase action is welcome |
…uesDataSourceHelper.
lvyanquan
force-pushed
the
SourceEventHelper
branch
from
f64f9f9 to
e719edc
Compare
…vide multiple splits case of ValuesDataSourceHelper.
lvyanquan
force-pushed
the
SourceEventHelper
branch
from
e719edc to
00d8b52
Compare
done. |
leonardBang
approved these changes
Nov 27, 2023
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
…BLE to mock source with multiple splits (apache#2737) This closes apache#2737.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…BLE to mock source with multiple splits (apache#2737) This closes apache#2737.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add MULTI_SPLITS_SINGLE_TABLE to provide multiple splits case of ValuesDataSourceHelper.