[cdc-common] add PublicEvolving annotation to SchemaUtils. #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvyanquan
force-pushed
the
schema-util
branch
from
6aaa753 to
4af9cbe
Compare
lvyanquan
force-pushed
the
schema-util
branch
2 times, most recently
from
b9b2deb to
83c2ab6
Compare
lvyanquan
commented
Nov 27, 2023
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(columns, primaryKeys, options, comment, nameToColumns); | ||
| return Objects.hash(columns, primaryKeys, options, comment); |
There was a problem hiding this comment.
remove it because it's initialized lazily.
lvyanquan
force-pushed
the
schema-util
branch
from
83c2ab6 to
ded82a4
Compare
PatrickRen
reviewed
Nov 28, 2023
| @@ -32,6 +33,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| /** Utils for {@link Schema} to perform the ability of evolution. */ | |||
| @PublicEvolving | |||
There was a problem hiding this comment.
As we are promoting this utility to public, I think we need to be careful about the API, so I have concerns about the method applySchemaChangeEvent with parameter ignoreException. I prefer to remove this one, as I can't see any use cases for ignoring exceptions. Currently there's no usage of it, and the warning log is empty if the exception is ignored, which confuses me a bit.
A better behavior would be clearly defining the exception on the method (throws XXXException) and letting the caller catch and handle it.
...time/src/main/java/com/ververica/cdc/runtime/operators/schema/coordinator/SchemaManager.java
Outdated
Show resolved
Hide resolved
|
Address it. And XXXException requires unified processing, so just keep to use IllegalArgumentException here. |
lvyanquan
force-pushed
the
schema-util
branch
from
945e661 to
03dee48
Compare
PatrickRen
approved these changes
Nov 28, 2023
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add PublicEvolving annotation to SchemaUtils, add modify code of SchemaManager to reuse the method of SchemaUtils.
@PatrickRen CC.