Skip to content

Conversation

@Laffery
Copy link
Contributor

@Laffery Laffery commented Apr 7, 2024

Optimize styles of the Flink CDC website documentation homepage:

  • support responsive styles to improve reading experience under mobile device.
  • optimize the background image to avoid large blank areas and increase the information content of the first screen
  • highlight theQuick Start button to help users find it well

Take iPhone 14pm (430px, 932px) for an example

Before:
image
image
image

After:
image
image
image

@github-actions github-actions bot added the docs Improvements or additions to documentation label Apr 7, 2024
@leonardBang
Copy link
Contributor

@GOODBOY008 Would you like to help review this PR?

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Laffery Please add / before fig. And ci will pass.

@Laffery
Copy link
Contributor Author

Laffery commented Apr 9, 2024

@GOODBOY008

Thanks for your kindly tips, I've finished and hope you review and trigger the CI again 🙏

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Laffery I left some suggestions.

@Laffery
Copy link
Contributor Author

Laffery commented Apr 12, 2024

@Laffery I left some suggestions.

Ohh it's really helpful on these details, I've commited again according to your suggestions.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Thanks @Laffery for your contributions. @leonardBang @Jiabao-Sun cc

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laffery for the contribution and @GOODBOY008 for the review, LGTM

@leonardBang leonardBang merged commit 9d150c0 into apache:master Apr 15, 2024
Laffery added a commit to Laffery/flink-cdc that referenced this pull request Jun 18, 2024
Laffery added a commit to Laffery/flink-cdc that referenced this pull request Jun 18, 2024
Laffery added a commit to Laffery/flink-cdc that referenced this pull request Jun 18, 2024
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants