-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[minor][cdc][docs] Optimize styles of the Flink CDC website docs home… #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@GOODBOY008 Would you like to help review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Laffery Please add / before fig. And ci will pass.
|
Thanks for your kindly tips, I've finished and hope you review and trigger the CI again 🙏 |
GOODBOY008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Laffery I left some suggestions.
Ohh it's really helpful on these details, I've commited again according to your suggestions. |
GOODBOY008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,Thanks @Laffery for your contributions. @leonardBang @Jiabao-Sun cc
leonardBang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Laffery for the contribution and @GOODBOY008 for the review, LGTM
Optimize styles of the Flink CDC website documentation homepage:
Quick Startbutton to help users find it wellTake iPhone 14pm (430px, 932px) for an example
Before:



After:


