Skip to content

[FLINK-35432]Support catch modify event for the mysql. #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruanhang1993 merged 3 commits into from
Aug 8, 2024
Merged

[FLINK-35432]Support catch modify event for the mysql. #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e5dae0
[FLINK-35432]Support catch modify event for the mysql.
May 23, 2024
9468f0f
[FLINK-35432]add unittest for modify sql.
May 23, 2024
2296330
[FLINK-35432]fixed checkstyle.
May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions ...a/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableParserListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,32 @@ public void enterAlterByRenameColumn(MySqlParser.AlterByRenameColumnContext ctx)
super.enterAlterByRenameColumn(ctx);
}

@Override
public void enterAlterByModifyColumn(MySqlParser.AlterByModifyColumnContext ctx) {
String oldColumnName = parser.parseName(ctx.uid(0));
ColumnEditor columnEditor = Column.editor().name(oldColumnName);
columnEditor.unsetDefaultValueExpression();

columnDefinitionListener =
new CustomColumnDefinitionParserListener(columnEditor, parser, listeners);
listeners.add(columnDefinitionListener);
super.enterAlterByModifyColumn(ctx);
}

@Override
public void exitAlterByModifyColumn(MySqlParser.AlterByModifyColumnContext ctx) {
parser.runIfNotNull(
() -> {
Column column = columnDefinitionListener.getColumn();
Map<String, DataType> typeMapping = new HashMap<>();
typeMapping.put(column.name(), fromDbzColumn(column));
changes.add(new AlterColumnTypeEvent(currentTable, typeMapping));
listeners.remove(columnDefinitionListener);
},
columnDefinitionListener);
super.exitAlterByModifyColumn(ctx);
}

@Override
public void exitAlterByRenameColumn(MySqlParser.AlterByRenameColumnContext ctx) {
parser.runIfNotNull(
Expand Down
8 changes: 8 additions & 0 deletions ...mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,14 @@ private List<Event> executeAlterAndProvideExpected(TableId tableId, Statement st
inventoryDatabase.getDatabaseName()));
expected.add(new RenameColumnEvent(tableId, Collections.singletonMap("desc1", "desc3")));

statement.execute(
String.format(
"ALTER TABLE `%s`.`products` MODIFY COLUMN `DESC3` VARCHAR(255) NULL DEFAULT NULL;",
inventoryDatabase.getDatabaseName()));
expected.add(
new AlterColumnTypeEvent(
tableId, Collections.singletonMap("DESC3", DataTypes.VARCHAR(255))));

statement.execute(
String.format(
"ALTER TABLE `%s`.`products` DROP COLUMN `DESC3`;",
Expand Down