Skip to content

[BP-3.1][FLINK-35295][mysql] Improve jdbc connection pool initialization failure message #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jiabao-Sun merged 1 commit into from
May 31, 2024
Merged

[BP-3.1][FLINK-35295][mysql] Improve jdbc connection pool initialization failure message #3374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...java/org/apache/flink/cdc/connectors/mysql/source/connection/PooledDataSourceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
package org.apache.flink.cdc.connectors.mysql.source.connection;

import org.apache.flink.cdc.connectors.mysql.source.config.MySqlSourceConfig;
import org.apache.flink.util.FlinkRuntimeException;

import com.zaxxer.hikari.HikariConfig;
import com.zaxxer.hikari.HikariDataSource;
import com.zaxxer.hikari.pool.HikariPool;
import io.debezium.connector.mysql.MySqlConnectorConfig;

import java.util.Properties;
Expand Down Expand Up @@ -60,7 +62,15 @@ public static HikariDataSource createPooledDataSource(MySqlSourceConfig sourceCo
config.addDataSourceProperty("prepStmtCacheSize", "250");
config.addDataSourceProperty("prepStmtCacheSqlLimit", "2048");

return new HikariDataSource(config);
try {
return new HikariDataSource(config);
} catch (HikariPool.PoolInitializationException e) {
throw new FlinkRuntimeException(
"Initialize jdbc connection pool failed, this may caused by"
+ " wrong jdbc configurations or unstable network."
+ " Please check your jdbc configurations and network.",
e);
}
}

private static String formatJdbcUrl(String hostName, int port, Properties jdbcProperties) {
Expand Down