-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[FLINK-35243] Extends schema change event types support #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c2a8bf8
[FLINK-35243] Extends schema change event type support
yuxiqian 215a4bf
Fix CI
yuxiqian 7e97e83
Fix CI
yuxiqian 4d429ee
Add truncate & drop tests
yuxiqian ed1b2a4
fix: mark api with annotations
yuxiqian e91a157
fix: use lambda instead of nested classes in visitors
yuxiqian dbafaf4
fix: codestyle
yuxiqian 5f4e19d
fix: favor JUnit 5
yuxiqian 0b341b6
fix: revert redundant changes
yuxiqian bfcf820
fix: do not drop table in lenient mode
yuxiqian 74b656c
remove debug lines
yuxiqian 635876c
log when ignoring drop table events
yuxiqian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/DropTableEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.cdc.common.event; | ||
|
|
||
| import org.apache.flink.cdc.common.annotation.PublicEvolving; | ||
| import org.apache.flink.cdc.common.source.DataSource; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * A {@link SchemaChangeEvent} that represents an {@code DROP TABLE} DDL. this will be sent by | ||
| * {@link DataSource} before all {@link DataChangeEvent} with the same tableId. | ||
| */ | ||
| @PublicEvolving | ||
| public class DropTableEvent implements SchemaChangeEvent { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final TableId tableId; | ||
|
|
||
| public DropTableEvent(TableId tableId) { | ||
| this.tableId = tableId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (!(o instanceof DropTableEvent)) { | ||
| return false; | ||
| } | ||
| DropTableEvent that = (DropTableEvent) o; | ||
| return Objects.equals(tableId, that.tableId); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(tableId); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DropTableEvent{" + "tableId=" + tableId + '}'; | ||
| } | ||
|
|
||
| @Override | ||
| public TableId tableId() { | ||
| return tableId; | ||
| } | ||
|
|
||
| @Override | ||
| public SchemaChangeEventType getType() { | ||
| return SchemaChangeEventType.DROP_TABLE; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...ommon/src/main/java/org/apache/flink/cdc/common/event/SchemaChangeEventWithPreSchema.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.cdc.common.event; | ||
|
|
||
| import org.apache.flink.cdc.common.annotation.PublicEvolving; | ||
| import org.apache.flink.cdc.common.schema.Schema; | ||
|
|
||
| /** A {@link SchemaChangeEvent} that supports appending schema before change event. */ | ||
| @PublicEvolving | ||
| public interface SchemaChangeEventWithPreSchema extends SchemaChangeEvent { | ||
|
|
||
| /** Describes if this event already has schema before change info. */ | ||
| boolean hasPreSchema(); | ||
|
|
||
| /** Append schema before change info to this event. */ | ||
| void fillPreSchema(Schema oldSchema); | ||
|
|
||
| /** Check if this event contains redundant schema change request only. */ | ||
| default boolean trimRedundantChanges() { | ||
| return false; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.