Skip to content

[hotfix][runtime] Invalidate cache correctly to avoid classloader leakage #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonardBang merged 1 commit into from
Aug 13, 2024
Merged

[hotfix][runtime] Invalidate cache correctly to avoid classloader leakage #3533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...in/java/org/apache/flink/cdc/runtime/operators/transform/TransformExpressionCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ public class TransformExpressionCompiler {

/** Triggers internal garbage collection of expired cache entries. */
public static void cleanUp() {
COMPILED_EXPRESSION_CACHE.cleanUp();
// com.google.common.cache.Cache from Guava isn't guaranteed to clear all cached records
// when invoking Cache#cleanUp, which may cause classloader leakage. Use #invalidateAll
// instead to ensure all key / value pairs to be correctly discarded.
COMPILED_EXPRESSION_CACHE.invalidateAll();
}

/** Compiles an expression code to a janino {@link ExpressionEvaluator}. */
Expand Down