Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize log level #3538

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Optimize log level #3538

wants to merge 5 commits into from

Conversation

melin
Copy link

@melin melin commented Aug 14, 2024

No description provided.

@yuxiqian
Copy link
Contributor

Hi @melin, seems the error log message you want to emit is Handling schema request in SchemaRegistry, which will be printed when an schema lookup request occurs. Changing it to DEBUG level is reasonable.

However, the log you've just modified will be printed only once for CreateTableEvents, which is significant and should not be classified to DEBUG level.

Maybe the log code you want to change is

LOG.info("Handling evolved schema request: {}", getEvolvedSchemaRequest);

and

LOG.info("Handling original schema request: {}", getOriginalSchemaRequest);

in SchemaRegistry.java?

@@ -224,7 +224,7 @@ private void handleCreateTableEvent(
!schemaExists(schemaMap, event.tableId()),
"Unable to apply CreateTableEvent to an existing schema for table \"%s\"",
event.tableId());
LOG.info("Handling schema change event: {}", event);
LOG.debug("Handling schema change event: {}", event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is not the text that floods your output log.

Copy link
Contributor

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @melin's work, changes look reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants