Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36407] Shut down coordinatorExecutor upon closing SchemaRegistry #3624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Sep 29, 2024

See the details in FLINK-36407. Not sure how this can be unit-tested given that the issue is not reproducible with JUnit.

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@morozov
Copy link
Contributor Author

morozov commented Sep 30, 2024

The MongoDB test failure looks irrelevant:

java.net.SocketException: Connection reset
 	at java.net.SocketInputStream.read(SocketInputStream.java:210) ~[?:1.8.0_422]
 	at java.net.SocketInputStream.read(SocketInputStream.java:141) ~[?:1.8.0_422]
 	at com.mongodb.internal.connection.SocketStream.read(SocketStream.java:175) ~[mongodb-driver-core-4.11.2.jar:?]
 	at com.mongodb.internal.connection.SocketStream.read(SocketStream.java:200) ~[mongodb-driver-core-4.11.2.jar:?]
 	at com.mongodb.internal.connection.InternalStreamConnection.receiveResponseBuffers(InternalStreamConnection.java:739) ~[mongodb-driver-core-4.11.2.jar:?]
 	at com.mongodb.internal.connection.InternalStreamConnection.receiveMessageWithAdditionalTimeout(InternalStreamConnection.java:603) ~[mongodb-driver-core-4.11.2.jar:?]
 	... 10 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants