[FLINK-36656][mysql] Fix type conversion failure for newly-added sharding table with mysql boolean type #3684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Nov 4, 2024
|
|
||
| private static void waitForSinkSize(String sinkName, int expectedSize) | ||
| throws InterruptedException { | ||
| while (sinkSize(sinkName) < expectedSize) { |
There was a problem hiding this comment.
I am concerned that if sinkSize(sinkName) is incorrectly less than expectedSize then we have an infinite loop.
I suggest having a time out on the while loop to ensure they complete in failure conditions after say 30 seconds.
Contributor
Author
There was a problem hiding this comment.
Nice catch and will adjust later, but as it's an existed method thus I tend to improve the tests infra in later PR, HDYT?
davidradl
reviewed
Nov 4, 2024
...test/java/org/apache/flink/cdc/connectors/mysql/table/MySqlConnectorShardingTableITCase.java
Show resolved
Hide resolved
…ding table with mysql boolean type
ruanhang1993
force-pushed
the
backport_Flink-36656
branch
from
ae668ec to
b3572e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport PR for release-3.2 branch