[hotfix] Remove broken MySQL incremental sources used in tests #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
leonardBang
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks @yuxiqian for the code cleanup, this package is used for framework verification, and it can be deleted safely now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a dummy incremental MySQL source in
flink-cdc-basetest module, but actually it never works since Debezium dependency was updated to 1.9.8. This problem never exposed since test cases offlink-cdc-basenever runs during CI.Since there are already various data sources (MongoDB, Db2, Oracle, Postgres) using this base, a broken mocking source seems no longer necessary and should be removed.