FLINK-36891: MySQL CDC connector produces corrupted state in case of serialization failure #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharonx
reviewed
Dec 12, 2024
| final byte[] result = out.getCopyOfBuffer(); | ||
| // optimization: cache the serialized from, so we avoid the byte work during repeated | ||
| // serialization | ||
| state.serializedFormCache = result; |
There was a problem hiding this comment.
I see the same chunk of code in the base folder https://github.com/apache/flink-cdc/blob/master/flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/state/PendingSplitsStateSerializer.java#L83-L104. Should it be fixed too?
| assertThrows(IOException.class, () -> serializer.serialize(unsupportedState)); | ||
|
|
||
| final byte[] ser2 = serializer.serialize(state); | ||
| assertEquals(ser1.length, ser2.length); |
There was a problem hiding this comment.
Is it better to assert that ser1 and ser2 are the same, since there shouldn't be any changes to the state if an error happens based on my understanding.
There was a problem hiding this comment.
For some reason, they aren't the same regardless of the fix.
UPD: you're right. They are equal, they just need to be compared as arrays, not objects.
…serialization failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the output buffer is reused between calls to
serialize(), it should be cleared in afinallyblock to account for potential exceptions.