[FLINK-36895] The JdbcSourceChunkSplitter#queryMin method passed a parameter with tableName/coiumnName reversed. #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter with tableName/coiumnName reversed.
|
Please help me close. It error pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JdbcChunkUtils#queryMin()
final String minQuery =
String.format(
"SELECT MIN(%s) FROM %s WHERE %s > ?",
quotedColumnName, quotedTableName, quotedColumnName);
but JdbcSourceChunkSplitter #queryMin
protected Object queryMin(
JdbcConnection jdbc, TableId tableId, Column splitColumn, Object excludedLowerBound)
throws SQLException
{ return JdbcChunkUtils.queryMin( jdbc, jdbc.quotedColumnIdString(splitColumn.name()), jdbc.quotedTableIdString(tableId), excludedLowerBound); }
Error passing column/tableId parameter. Resulting in the generated sql "select tableId from columnID".
we need sql "select columnid from tableId"