Skip to content

[FLINK-36970][runtime] Merge result of data type BIGINT and DOUBLE should be DOUBLE instead of STRING #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonardBang merged 2 commits into from
Jan 9, 2025
Merged

[FLINK-36970][runtime] Merge result of data type BIGINT and DOUBLE should be DOUBLE instead of STRING #3821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95a2684
[FLINK-36970][runtime] data type merge result of BIGINT and DOUBLE sh…
Shawn-Hx Dec 27, 2024
105bb51
update outdated comments
Shawn-Hx Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaMergingUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,9 @@ private static Map<Class<? extends DataType>, List<DataType>> getTypeMergingTree
mergingTree.put(DoubleType.class, ImmutableList.of(doubleType, stringType));
mergingTree.put(FloatType.class, ImmutableList.of(floatType, doubleType, stringType));
mergingTree.put(DecimalType.class, ImmutableList.of(stringType));
mergingTree.put(BigIntType.class, ImmutableList.of(bigIntType, decimalType, stringType));
mergingTree.put(
BigIntType.class,
ImmutableList.of(bigIntType, decimalType, doubleType, stringType));
mergingTree.put(
IntType.class,
ImmutableList.of(intType, bigIntType, decimalType, doubleType, stringType));
Expand Down
10 changes: 5 additions & 5 deletions flink-cdc-common/src/test/java/org/apache/flink/cdc/common/utils/SchemaMergingUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,15 +975,15 @@ void testGetLeastCommonType() {
DECIMAL, FLOAT, DOUBLE, STRING, STRING, STRING, STRING, STRING, STRING,
STRING));

// 16-bit TINYINT could fit into FLOAT (24 sig bits) or DOUBLE (53 sig bits)
// 16-bit SMALLINT could fit into FLOAT (24 sig bits) or DOUBLE (53 sig bits)
assertTypeMergingVector(
SMALLINT,
Arrays.asList(
STRING, STRING, STRING, STRING, STRING, SMALLINT, SMALLINT, INT, BIGINT,
DECIMAL, FLOAT, DOUBLE, STRING, STRING, STRING, STRING, STRING, STRING,
STRING));

// 32-bit TINYINT could fit into DOUBLE (53 sig bits)
// 32-bit INT could fit into DOUBLE (53 sig bits)
assertTypeMergingVector(
INT,
Arrays.asList(
Expand All @@ -994,7 +994,7 @@ void testGetLeastCommonType() {
BIGINT,
Arrays.asList(
STRING, STRING, STRING, STRING, STRING, BIGINT, BIGINT, BIGINT, BIGINT,
DECIMAL, STRING, STRING, STRING, STRING, STRING, STRING, STRING, STRING,
DECIMAL, DOUBLE, DOUBLE, STRING, STRING, STRING, STRING, STRING, STRING,
STRING));

assertTypeMergingVector(
Expand All @@ -1007,14 +1007,14 @@ void testGetLeastCommonType() {
assertTypeMergingVector(
FLOAT,
Arrays.asList(
STRING, STRING, STRING, STRING, STRING, FLOAT, FLOAT, DOUBLE, STRING,
STRING, STRING, STRING, STRING, STRING, FLOAT, FLOAT, DOUBLE, DOUBLE,
STRING, FLOAT, DOUBLE, STRING, STRING, STRING, STRING, STRING, STRING,
STRING));

assertTypeMergingVector(
DOUBLE,
Arrays.asList(
STRING, STRING, STRING, STRING, STRING, DOUBLE, DOUBLE, DOUBLE, STRING,
STRING, STRING, STRING, STRING, STRING, DOUBLE, DOUBLE, DOUBLE, DOUBLE,
STRING, DOUBLE, DOUBLE, STRING, STRING, STRING, STRING, STRING, STRING,
STRING));

Expand Down
Loading