Skip to content

[hotfix][ci] Use raise to fix uncaught throw #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whhe wants to merge 2 commits into from
Closed

[hotfix][ci] Use raise to fix uncaught throw #3909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da42834
hotfix: use raise to fix uncaught throw
whhe Feb 6, 2025
858d346
modify migration waiting time
whhe Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/mig-test/datastream/run_migration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
require 'pathname'
require 'securerandom'

WAITING_SECONDS = 20
WAITING_SECONDS = 30
FLINK_HOME = ENV['FLINK_HOME']
throw 'Unspecified `FLINK_HOME` environment variable.' if FLINK_HOME.nil?
FLINK_HOME = Pathname.new(FLINK_HOME).realpath
Expand All @@ -37,7 +37,7 @@ def put_mystery_data(mystery)
end

def ensure_mystery_data(mystery)
throw StandardError, 'Failed to get specific mystery string' unless `cat #{FLINK_HOME}/log/*.out`.include? mystery
raise StandardError, 'Failed to get specific mystery string' unless `cat #{FLINK_HOME}/log/*.out`.include? mystery
end

puts ' Waiting for source to start up...'
Expand Down
4 changes: 2 additions & 2 deletions tools/mig-test/run_migration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
require 'pathname'
require 'securerandom'

WAITING_SECONDS = 20
WAITING_SECONDS = 30
FLINK_HOME = ENV['FLINK_HOME']
throw 'Unspecified `FLINK_HOME` environment variable.' if FLINK_HOME.nil?
FLINK_HOME = Pathname.new(FLINK_HOME).realpath
Expand All @@ -37,7 +37,7 @@ def put_mystery_data(mystery)
end

def ensure_mystery_data(mystery)
throw StandardError, 'Failed to get specific mystery string' unless `cat #{FLINK_HOME}/log/*.out`.include? mystery
raise StandardError, 'Failed to get specific mystery string' unless `cat #{FLINK_HOME}/log/*.out`.include? mystery
end

def extract_job_id(output)
Expand Down
Loading