Skip to content

[FLINK-38429] Reuse OperationSerializer in Elasticsearch 8 connector to improve perf #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FLINK-38429] Reuse OperationSerializer in Elasticsearch 8 connector to improve perf #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...rc/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ public class Elasticsearch8AsyncWriter<InputT> extends AsyncSinkWriter<InputT, O
/** A counter to track the number of bulk requests that are sent to Elasticsearch. */
private final Counter numRequestSubmittedCounter;

private final OperationSerializer operationSerializer;

private static final FatalExceptionClassifier ELASTICSEARCH_FATAL_EXCEPTION_CLASSIFIER =
FatalExceptionClassifier.createChain(
new FatalExceptionClassifier(
Expand Down Expand Up @@ -112,6 +114,7 @@ public Elasticsearch8AsyncWriter(
this.numRecordsSendPartialFailureCounter =
metricGroup.counter("numRecordsSendPartialFailure");
this.numRequestSubmittedCounter = metricGroup.counter("numRequestSubmitted");
this.operationSerializer = new OperationSerializer();
}

@Override
Expand Down Expand Up @@ -192,7 +195,7 @@ private boolean isRetryable(Throwable error) {

@Override
protected long getSizeInBytes(Operation requestEntry) {
return new OperationSerializer().size(requestEntry);
return operationSerializer.size(requestEntry);
}

@Override
Expand Down