Skip to content

[FLINK-38054] flink-connector-elasticsearch8 use correct ClassLoader in OperationSerializer #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FLINK-38054] flink-connector-elasticsearch8 use correct ClassLoader in OperationSerializer #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ec872f
[FLINK-38054] flink-connector-elasticsearch8 use correct ClassLoader …
mayorandrew Nov 7, 2025
209b7af
[FLINK-38054] flink-connector-elasticsearch8 use custom serializer fo…
mayorandrew Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...rch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/OperationSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@
package org.apache.flink.connector.elasticsearch.sink;

import com.esotericsoftware.kryo.Kryo;
import com.esotericsoftware.kryo.Serializer;
import com.esotericsoftware.kryo.io.Input;
import com.esotericsoftware.kryo.io.Output;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.objenesis.strategy.StdInstantiatorStrategy;

import java.io.ByteArrayOutputStream;
Expand All @@ -33,10 +36,13 @@
/** OperationSerializer is responsible for serialization and deserialization of an Operation. */
public class OperationSerializer {
private final Kryo kryo = new Kryo();
private static final ObjectMapper MAPPER = new ObjectMapper();

public OperationSerializer() {
kryo.setRegistrationRequired(false);
kryo.setInstantiatorStrategy(new StdInstantiatorStrategy());
kryo.addDefaultSerializer(JsonNode.class, new JsonNodeSerializer());
kryo.setClassLoader(Thread.currentThread().getContextClassLoader());
}

public void serialize(Operation request, DataOutputStream out) {
Expand All @@ -61,4 +67,28 @@ public int size(Operation operation) {
return (int) output.total();
}
}

private static class JsonNodeSerializer extends Serializer<JsonNode> {
@Override
public void write(Kryo kryo, Output output, JsonNode object) {
try {
byte[] bytes = MAPPER.writeValueAsBytes(object);
output.writeInt(bytes.length, true);
output.writeBytes(bytes);
} catch (Exception e) {
throw new RuntimeException("Failed to serialize JsonNode", e);
}
}

@Override
public JsonNode read(Kryo kryo, Input input, Class<JsonNode> type) {
try {
int length = input.readInt(true);
byte[] bytes = input.readBytes(length);
return MAPPER.readTree(bytes);
} catch (Exception e) {
throw new RuntimeException("Failed to deserialize JsonNode", e);
}
}
}
}