[FLINK-33542] Update tests to JUnit5 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferenc-csaky
force-pushed
the
FLINK-33542
branch
from
8ebe188 to
de6cda6
Compare
|
@Tan-JiaLiang if you have some time, can you take a look pls? |
| public static final MiniClusterWithClientResource MINI_CLUSTER = | ||
| new MiniClusterWithClientResource( | ||
| @RegisterExtension | ||
| private static final MiniClusterExtension MINI_CLUSTER_EXTENSION = |
There was a problem hiding this comment.
There is moving to HBaseTestingClusterAutoStarter already, maybe we can remove it.
There was a problem hiding this comment.
I checked the commit that added this (FLINK-24077) and it was introduced to fix a flaky test, so I went with the dummy approach to keep it as close to the state it was before. But since this code lives in a separate repo now and the underlying logic with JUnit5 might do not have that defect anyways I think it can be removed. If it introduces test flakiness again, we will know the probable source.
...onnector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java
Show resolved
Hide resolved
ferenc-csaky
force-pushed
the
FLINK-33542
branch
from
de6cda6 to
d1d88bd
Compare
MartijnVisser
pushed a commit
that referenced
this pull request
Nov 17, 2023
* [FLINK-33542] Update tests to JUnit5 * Remove remaining "public" modifiers from test methods * Remove unnecessary mini cluster extension (cherry picked from commit a36b137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the existing tests to JUnit5.
Except
HBaseTablePlanTest, which is based onTableTestBasefrom the core Flink repo, that is still on JUnit4.