Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37212] When hbase region move, throw "Unable to load exception received from server: XXX" #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chunji96
Copy link

When Hbase Region move , will cause ' Unable to load exception received from :xxx'. detail can see : FLINK-37212

Copy link

boring-cyborg bot commented Jan 24, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! The logic itself LG, added 2 minor comments.

Comment on lines +147 to +148
<exclude>org/apache/hadoop/hbase/NotServingRegionException</exclude>
<exclude>org/apache/hadoop/hbase/exceptions/RegionMovedException</exclude>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pls. replace / to . to keep this section consistent? It works that way the same as well.

Copy link
Contributor

@ferenc-csaky ferenc-csaky Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extend the comment starting @ L142 with something like:

Some exceptions also required to keep their original package because the region
server sends it that way, and otherwise the client will not recognize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants