[FLINK-32068] connector jdbc support clickhouse #49

WenDing-Y · 2023-05-18T15:56:07Z

the clickhouse in batch mode ,as sink and source
the clickhouse in streaming mode ,as sink

boring-cyborg · 2023-05-18T15:56:10Z

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

MartijnVisser · 2023-05-24T10:18:07Z

@WenDing-Y Could you please rebase?

WenDing-Y · 2023-05-24T17:20:29Z

Okay, I have rebased, but I found that there were quite a few modifications in the testing section. I have already submitted some code, but the unit test cannot pass now. I am still modifying this section. @MartijnVisser

WenDing-Y · 2023-05-25T13:42:07Z

the pr is ready

WenDing-Y · 2023-05-29T12:11:59Z

Please help me review, thank you very much @snuyanzin

eskabetxe · 2023-05-30T08:30:34Z

flink-connector-jdbc/pom.xml

+		<dependency>
+			<groupId>org.testcontainers</groupId>
+			<artifactId>clickhouse</artifactId>
+			<version>1.18.1</version>


this is not needed as testcontainers-bom is defined on parent..

if needed should be used ${testcontainers.version} to use same version defined

The testcontainer in the parent pom corresponds to ru.yandex.clickhouse.ClickHouseDriver, but this driver has stopped maintenance, so I have declared a new version of the image here, corresponding to the driver com.clickhouse.jdbc.ClickHouseDriver

I hope you can give me some advice on how to handle it. Thank you very much

we can update the version on parent

If I modify this version number in parent pom.xml, it will affect other testcontainers

the parent pom is

<dependency> <groupId>org.testcontainers</groupId> <artifactId>testcontainers-bom</artifactId> <version>${testcontainers.version}</version> <type>pom</type> <scope>import</scope> </dependency>

we have update master.. if you rebase will be available the last version o testcontainers

ok,I have deleted the specified version @eskabetxe

eskabetxe · 2023-05-30T08:37:54Z

...connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/tables/TableBase.java

+        return fields;
+    }
+
+    public String getName() {


already exist a getTableName()

Ok, I have deleted it

eskabetxe · 2023-05-30T08:49:39Z

...test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java

+                getTableName(),
+                getStreamFields().map(TableField::asString).collect(Collectors.joining(", ")),
+                "ENGINE = MergeTree",
+                getStreamFields().map(TableField::getName).findFirst().get());


you are ignoring the PKs defined in table definition with this...

eskabetxe · 2023-05-30T08:50:23Z

...test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java

+        return String.format("truncate table %s", getTableName());
+    }
+
+    private Stream<TableField> getStreamFields() {


TableBase already have a getStreamFields()

This method is private, can I change it to protected

eskabetxe · 2023-05-30T08:50:50Z

...test/java/org/apache/flink/connector/jdbc/databases/clickhouse/table/ClickhouseTableRow.java

+        return String.format(
+                "CREATE TABLE %s (%s) %s PRIMARY KEY (%s)",
+                getTableName(),
+                getStreamFields().map(TableField::asString).collect(Collectors.joining(", ")),


as this is also used on TableBase could we create a method for it there?

The syntax for creating a table in the clickhouse like
CREATE TABLE my_first_table ( user_id UInt32, message String, timestamp DateTime, metric Float32 ) ENGINE = MergeTree PRIMARY KEY (user_id, timestamp)
somewhat different from standard SQL, so I think it is reasonable for ClickhouseTableRow to extend TableBase and then Override the getCreateQuery method. If I put it in TableBase, I also need to choose different methods based on the dialect to obtain the statement for creating the table

eskabetxe · 2023-05-30T08:52:19Z

...tor-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java

@@ -322,6 +325,9 @@ void testBatchSink() throws Exception {

    @Test
    void testReadingFromChangelogSource() throws Exception {
+        if (!getMetadata().supportUpsert()) {


Here the problem is the deletion no? (I have this same problem in Trino dialect)

If I remove this judgment, this test case will fail. I would like to hear your opinion on how to handle this issue

the approach is fine, I only dont know if the name of method is the correct (supportUpsert)..

Ok, I will modify this issue later

I have updated the method name

eskabetxe · 2023-05-30T08:52:56Z

...connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/tables/TableBase.java

@@ -291,4 +291,12 @@ protected <T> T getNullable(ResultSet rs, FunctionWithException<ResultSet, T, SQ
    protected <T> T getNullable(ResultSet rs, T value) throws SQLException {
        return rs.wasNull() ? null : value;
    }
+
+    public TableField[] getFields() {


for the use I see you should use getStreamFields()

this is not used, could be removed

WenDing-Y · 2023-05-31T13:34:07Z

compile_and_test (1.18-SNAPSHOT) fail, It doesn't seem like the problem was caused by my submission

WenDing-Y · 2023-05-31T14:01:58Z

Please help me review, where else can I improve? Thank you very much @eskabetxe

WenDing-Y · 2023-06-02T03:54:22Z

What other tasks are needed for this PR to merge

MartijnVisser · 2023-06-05T06:56:27Z

What other tasks are needed for this PR to merge

You will need to rebase, because there are a couple of merge commits when you merged main into your branch. Those merge commits prevent merging; by rebasing, those commits should not be needed anymore

WenDing-Y · 2023-06-05T13:05:10Z

Ok, I have rebase @MartijnVisser

MartijnVisser · 2023-06-05T13:14:29Z

Ok, I have rebase @MartijnVisser

I don't think you have, given that there are 4 merge-commits in this PR which shouldn't be there when rebased properly: bb13e1f bced473 9abdfaf 2655b6b

snuyanzin · 2023-06-05T13:16:50Z

...jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java

+    // Define MAX/MIN precision of TIMESTAMP type according to Mysql docs:
+    // https://dev.mysql.com/doc/refman/8.0/en/fractional-seconds.html


Shouldn't we refer here to Clickhouse doc?

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

snuyanzin · 2023-06-05T13:16:57Z

...jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java

+    private static final int MIN_TIMESTAMP_PRECISION = 1;
+
+    // Define MAX/MIN precision of DECIMAL type according to Mysql docs:
+    // https://dev.mysql.com/doc/refman/8.0/en/fixed-point-types.html


Shouldn't we refer here to Clickhouse doc?

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

snuyanzin · 2023-06-05T13:18:04Z

...c/src/main/java/org/apache/flink/connector/jdbc/internal/converter/ClickhouseRowConvert.java

+import org.apache.flink.connector.jdbc.converter.AbstractJdbcRowConverter;
+import org.apache.flink.table.types.logical.RowType;
+
+/** */


well it's better to have some description about the class rather than an empty comment

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

snuyanzin · 2023-06-05T13:18:09Z

...c/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java

+import org.apache.flink.connector.jdbc.dialect.JdbcDialect;
+import org.apache.flink.connector.jdbc.dialect.JdbcDialectFactory;
+
+/** */


well it's better to have some description about the class rather than an empty comment

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

snuyanzin · 2023-06-05T13:18:16Z

...jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java

+import java.util.Optional;
+import java.util.Set;
+
+/** */


well it's better to have some description about the class rather than an empty comment

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

snuyanzin · 2023-06-05T13:23:20Z

.../java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseRowConvert.java

+                    } else if (jdbcField instanceof Long) {
+                        return ((Long) jdbcField).longValue();
+                    }
+                    // UINT64 is not supported,the uint64 range exceeds the long range


can we use BigInteger for UINT64?

the clickhouse data types range
UInt8 — [0 : 255]
UInt16 — [0 : 65535]
UInt32 — [0 : 4294967295]
UInt64 — [0 : 18446744073709551615]
UInt128 — [0 : 340282366920938463463374607431768211455]
UInt256 — [0 : 115792089237316195423570985008687907853269984665640564039457584007913129639935]

i still don't see the issue why for UInt64, UInt128, UInt256 we can not return BigInteger ?

snuyanzin · 2023-06-05T13:27:18Z

Sorry i was late here, thanks for your PR @WenDing-Y
The thing that I do not understand...
why do we need 2 ClickhouseDialect classes

flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialect.java

and
2 ClickhouseDialectFactory

flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectFactory.java
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java

WenDing-Y · 2023-06-05T16:18:34Z

Ok, I have rebase @MartijnVisser

I don't think you have, given that there are 4 merge-commits in this PR which shouldn't be there when rebased properly: bb13e1f bced473 9abdfaf 2655b6b

Sorry, it's my problem. I have rebase it again @MartijnVisser

WenDing-Y · 2023-06-05T16:21:42Z

Sorry i was late here, thanks for your PR @WenDing-Y The thing that I do not understand... why do we need 2 ClickhouseDialect classes

flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialect.java

and 2 ClickhouseDialectFactory

flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectFactory.java
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java

Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved

MartijnVisser · 2023-06-05T17:28:08Z

Now this has always been resolved

Unfortunately it hasn't been resolved. In case you want to rebase, what you should do is the following (this is assuming that you've added this repository as a remote called upstream.)

Run git fetch upstream
Run git rebase upstream/main and complete this until the rebase has successfully completed
Force push your changes to your branch

WenDing-Y · 2023-06-06T05:32:26Z

Now this has always been resolved

Unfortunately it hasn't been resolved. In case you want to rebase, what you should do is the following (this is assuming that you've added this repository as a remote called upstream.)

Run git fetch upstream

Run git rebase upstream/main and complete this until the rebase has successfully completed

Force push your changes to your branch

It seems like this, my local submit history, the new feature started working after [Flink-31551]
@MartijnVisser

snuyanzin · 2023-06-06T05:49:14Z

if you execute this command on your branch

git log --pretty-oneline

you'll se several merge remote-tracking commits like

c9e316596dc29fe3cb60578f53dce3b2b7fa8c1a (HEAD, WenDing/jdbc-clickhouse) Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse
9098ce56b0d703cda0a1f24f69058b9ab15af556 [FLINK-32068]connector jdbc support clickhouse
8f6eff4e98003d568da8e722c06167dd491d4b53 [FLINK-32068]connector jdbc support clickhouse
79cc7987be514afd0580d377208c798ec04a9415 [FLINK-32068] jdbc support clickhouse
210968dca5a1fb47cd3268fa130f0ff5e54f299c [FLINK-32068]connector jdbc support clickhouse
c49485360a58e12ce7aad13ee627dcecc74c891e [FLINK-32068] connector jdbc support clickhouse
00c94f815e8fda71777a83d63bd1e14111bc5650 [FLINK-32068] connector jdbc support clickhouse
cd268a2111ecfd0602f4150d5b1cc44b99779456 [FLINK-32068] connector jdbc support clickhouse
86b5eeee7b88c1ef46f7d768875762ae253eec97 [FLINK-32068] connector jdbc support clickhouse
b81bc533fb98da2e5a76bddb22a4da8a52fb411e [FLINK-32068]connector jdbc support clickhouse
55f79f215456c0dbb5fdd3d99a8be6985be092ef [FLINK-32068]connector jdbc support clickhouse
1ff9e70dfbeefaa2e92c11db36fcca3c27bf9b49 Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse
b6663a5fced2e4703c263827ca67c2dbacbf96bd [FLINK-32068]connector jdbc support clickhouse
2655b6badefbea699ddb2465803076ec229b884b Merge remote-tracking branch 'origin/main' into jdbc-clickhouse
9abdfafac76b17dcce371239ff5e16d9b90b9980 Merge branch 'main' into jdbc-clickhouse
d67de5f0f94b1de912470028ea1fc74376bd64b8 [FLINK-31551] Add support for CrateDB (#29)
7b8617e03048d32d44dc453bd556d9f59d58a3e1 [FLINK-32068]connector jdbc support clickhouse,delete testcontainers version
bced473fbb8a606dca287fcf9329c7f052b9c4be Merge remote-tracking branch 'upstream/main' into jdbc-clickhouse

and this the issue

WenDing-Y · 2023-06-06T06:08:38Z

if you execute this command on your branch

git log --pretty-oneline

you'll se several merge remote-tracking commits like

c9e316596dc29fe3cb60578f53dce3b2b7fa8c1a (HEAD, WenDing/jdbc-clickhouse) Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse
9098ce56b0d703cda0a1f24f69058b9ab15af556 [FLINK-32068]connector jdbc support clickhouse
8f6eff4e98003d568da8e722c06167dd491d4b53 [FLINK-32068]connector jdbc support clickhouse
79cc7987be514afd0580d377208c798ec04a9415 [FLINK-32068] jdbc support clickhouse
210968dca5a1fb47cd3268fa130f0ff5e54f299c [FLINK-32068]connector jdbc support clickhouse
c49485360a58e12ce7aad13ee627dcecc74c891e [FLINK-32068] connector jdbc support clickhouse
00c94f815e8fda71777a83d63bd1e14111bc5650 [FLINK-32068] connector jdbc support clickhouse
cd268a2111ecfd0602f4150d5b1cc44b99779456 [FLINK-32068] connector jdbc support clickhouse
86b5eeee7b88c1ef46f7d768875762ae253eec97 [FLINK-32068] connector jdbc support clickhouse
b81bc533fb98da2e5a76bddb22a4da8a52fb411e [FLINK-32068]connector jdbc support clickhouse
55f79f215456c0dbb5fdd3d99a8be6985be092ef [FLINK-32068]connector jdbc support clickhouse
1ff9e70dfbeefaa2e92c11db36fcca3c27bf9b49 Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse
b6663a5fced2e4703c263827ca67c2dbacbf96bd [FLINK-32068]connector jdbc support clickhouse
2655b6badefbea699ddb2465803076ec229b884b Merge remote-tracking branch 'origin/main' into jdbc-clickhouse
9abdfafac76b17dcce371239ff5e16d9b90b9980 Merge branch 'main' into jdbc-clickhouse
d67de5f0f94b1de912470028ea1fc74376bd64b8 [FLINK-31551] Add support for CrateDB (#29)
7b8617e03048d32d44dc453bd556d9f59d58a3e1 [FLINK-32068]connector jdbc support clickhouse,delete testcontainers version
bced473fbb8a606dca287fcf9329c7f052b9c4be Merge remote-tracking branch 'upstream/main' into jdbc-clickhouse

and this the issue

What else do I need to do? I executed it
1.Run git fetch upstream
2.Run git rebase upstream/main and complete this until the rebase has successfully completed
3.Force push your changes to your branch

snuyanzin · 2023-06-06T07:35:13Z

how do you recognize that rebase has successfully completed?
I tried to do it with your branch (git rebase upstream/main) and got a number of conflicts

WenDing-Y · 2023-07-11T12:19:36Z

One question that comes to my mind now.. This will only work with a 1 server no? if we have a Clickhouse cluster with more than 1 server (that will have a zookeeper envolved) will not work no?
if this is true, I think we should have a note on documentation

I tried to work normally in cluster mode

My steps are as follows 1.create ck table
create table if not exists default.ck_flink_test_local on cluster clicks_cluster
(
    user_id Int32,
    message String
)
engine = ReplicatedMergeTree('/clickhouse/tables/{shard}/ck_flink_test_local', '{replica}')
PRIMARY KEY (user_id)




create table if not exists default.ck_flink_test on cluster clicks_cluster
(
user_id Int32,
    message String
)
engine = Distributed('clicks_cluster', 'default', 'ck_flink_test_local', user_id);
in flink sql client
CREATE TABLE ck_flink_test(
   user_id INTEGER,
  message String
) WITH (
  'connector' = 'jdbc',
  'url' = 'jdbc:clickhouse://xx:xx/default',
 'table-name' = 'ck_flink_test',
 'username’='xx',
 'password’='xx'
);
exec insert sql
INSERT INTO ck_flink_test (user_id, message) VALUES
    (101, 'Hello');
thd data can be viewed on the ck client
select * from ck_flink_test;
5.the flink sql client

WenDing-Y · 2023-07-11T12:21:08Z

One question that comes to my mind now.. This will only work with a 1 server no? if we have a Clickhouse cluster with more than 1 server (that will have a zookeeper envolved) will not work no?
if this is true, I think we should have a note on documentation

I tried to work normally in cluster mode

My steps are as follows 1.create ck table
create table if not exists default.ck_flink_test_local on cluster clicks_cluster
(
    user_id Int32,
    message String
)
engine = ReplicatedMergeTree('/clickhouse/tables/{shard}/ck_flink_test_local', '{replica}')
PRIMARY KEY (user_id)




create table if not exists default.ck_flink_test on cluster clicks_cluster
(
user_id Int32,
    message String
)
engine = Distributed('clicks_cluster', 'default', 'ck_flink_test_local', user_id);
in flink sql client
CREATE TABLE ck_flink_test(
   user_id INTEGER,
  message String
) WITH (
  'connector' = 'jdbc',
  'url' = 'jdbc:clickhouse://xx:xx/default',
 'table-name' = 'ck_flink_test',
 'username’='xx',
 'password’='xx'
);
exec insert sql
INSERT INTO ck_flink_test (user_id, message) VALUES
    (101, 'Hello');
thd data can be viewed on the ck client
select * from ck_flink_test;
5.the flink sql client

@eskabetxe I guess you might have defined the table incorrectly

Edward-Gavin · 2024-11-03T13:21:42Z

@WenDing-Y hello, in our project, we want to import data to clickhouse. Now this PR no longer merges with the main branch?

boring-cyborg bot added the component=Connectors/JDBC label May 18, 2023

WenDing-Y changed the title ~~FLINK-32068 connector jdbc support clickhouse~~ [FLINK-32068] connector jdbc support clickhouse May 18, 2023

MartijnVisser requested a review from snuyanzin May 25, 2023 14:37

eskabetxe suggested changes May 30, 2023

View reviewed changes

snuyanzin reviewed Jun 5, 2023

View reviewed changes

WenDing-Y force-pushed the jdbc-clickhouse branch from b20eb66 to 59b1122 Compare June 6, 2023 14:52

WenDing-Y closed this Jul 11, 2023

WenDing-Y reopened this Jul 11, 2023

WenDing-Y and others added 24 commits July 12, 2023 23:20

[FLINK-32068]connector jdbc support clickhouse

d9039c4

[FLINK-32068] connector jdbc support clickhouse

21d15e0

[FLINK-32068] connector jdbc support clickhouse

223a9cb

[FLINK-32068] connector jdbc support clickhouse

b0e7b37

[FLINK-32068] connector jdbc support clickhouse ,support map types

d1f96df

[FLINK-32068]connector jdbc support clickhouse

036a67f

[FLINK-32068] jdbc support clickhouse

c8decbe

[FLINK-32068]connector jdbc support clickhouse

6d4a0d5

[FLINK-32068]connector jdbc support clickhouse

8b1df04

[FLINK-32068] connector jdbc support clickhouse

9c75447

[FLINK-32068] connector jdbc support clickhouse

4975492

[FLINK-32068]connector jdbc support clickhouse

9ee3d1f

[FLINK-32068]connector jdbc support clickhouse

924c107

[FLINK-32068] jdbc support clickhouse

a56e098

[FLINK-32068]connector jdbc support clickhouse

7caac6f

[FLINK-32068]connector jdbc support clickhouse

8f13540

[FLINK-32068] connector jdbc support clickhouse

cd9ba3f

[FLINK-32068]connector jdbc support clickhouse

1a43dfe

[FLINK-32068]connector jdbc support clickhouse

afce802

[FLINK-32068] jdbc support clickhouse

ef91923

[FLINK-32068]connector jdbc support clickhouse

4d0aa96

[FLINK-32068] connector jdbc support clickhouse

b597ed3

[FLINK-32068] connector jdbc support clickhouse ,support map types

6ce9bf9

[FLINK-32068] connector jdbc support clickhouse ,fix test fail

4facf4c

WenDing-Y force-pushed the jdbc-clickhouse branch from 667e72b to 4facf4c Compare July 12, 2023 15:24

		// Define MAX/MIN precision of TIMESTAMP type according to Mysql docs:
		// https://dev.mysql.com/doc/refman/8.0/en/fractional-seconds.html

[FLINK-32068] connector jdbc support clickhouse #49

Are you sure you want to change the base?

[FLINK-32068] connector jdbc support clickhouse #49

Conversation

WenDing-Y commented May 18, 2023

boring-cyborg bot commented May 18, 2023

MartijnVisser commented May 24, 2023

WenDing-Y commented May 24, 2023

WenDing-Y commented May 25, 2023

WenDing-Y commented May 29, 2023

eskabetxe May 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WenDing-Y Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WenDing-Y May 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WenDing-Y commented May 31, 2023

WenDing-Y commented May 31, 2023

WenDing-Y commented Jun 2, 2023

MartijnVisser commented Jun 5, 2023

WenDing-Y commented Jun 5, 2023

MartijnVisser commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WenDing-Y Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

snuyanzin Jun 7, 2023 • edited Loading

Choose a reason for hiding this comment

snuyanzin commented Jun 5, 2023 • edited Loading

WenDing-Y commented Jun 5, 2023

WenDing-Y commented Jun 5, 2023

MartijnVisser commented Jun 5, 2023

WenDing-Y commented Jun 6, 2023 • edited Loading

snuyanzin commented Jun 6, 2023 • edited Loading

WenDing-Y commented Jun 6, 2023

snuyanzin commented Jun 6, 2023 • edited Loading

WenDing-Y commented Jul 11, 2023

WenDing-Y commented Jul 11, 2023

Edward-Gavin commented Nov 3, 2024

eskabetxe May 30, 2023 •

edited

Loading

WenDing-Y Jun 1, 2023 •

edited

Loading

WenDing-Y May 30, 2023 •

edited

Loading

WenDing-Y Jun 5, 2023 •

edited

Loading

snuyanzin Jun 7, 2023 •

edited

Loading

snuyanzin commented Jun 5, 2023 •

edited

Loading

WenDing-Y commented Jun 6, 2023 •

edited

Loading

snuyanzin commented Jun 6, 2023 •

edited

Loading

snuyanzin commented Jun 6, 2023 •

edited

Loading