Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][docs] Adds clean to Maven command in README file #121

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Aug 2, 2023

The build should be done on a fresh checkout of the flink-shaded repository. Otherwise, we might run into errors in the jackson submodule:

$ mvn install -Dshade-sources
[...]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (shade-flink) on project flink-shaded-jackson: Error creating shaded jar: duplicate entry: META-INF/services/org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonFactory -> [Help 1]                                                            
[ERROR]                                                                                                                                                                                                                                                                                                                                            
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.                                                                                                                                                                                                                                                                
[ERROR] Re-run Maven using the -X switch to enable full debug logging.                                                                                                                                                                                                                                                                             
[ERROR]                                                                                                                                                                                                                                                                                                                                            
[ERROR] For more information about the errors and possible solutions, please read the following articles:                                                                                                                                                                                                                                          
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException                                                                                                                                                                                                                                                           
[ERROR]                                                                                                                                                                                                                                                                                                                                            
[ERROR] After correcting the problems, you can resume the build with the command                                                                                                                                                                                                                                                                   
[ERROR]   mvn <args> -rf :flink-shaded-jackson

I didn't check where this error is coming from. But building the sources based on a clean version sounds reasonable in general.

The build should be done on a fresh checkout of the flink-shaded repository. Otherwise,
we might run into errors in the jackson submodule: Error creating shaded jar: duplicate
entry: META-INF/services/org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonFactory

I didn't check where this error is coming from. But building the sources based
on a clean version sounds reasonable in general.
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartijnVisser MartijnVisser merged commit 2eff4e2 into master Oct 23, 2023
2 checks passed
@MartijnVisser MartijnVisser deleted the hotfix-clean-install-readme-fix branch October 23, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants