-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33417][netty] Upgrade 4.1.82 -> 4.1.83 #127
Conversation
e3c2013
to
801a00d
Compare
801a00d
to
a89778c
Compare
thanks @TanYuxin-tyx - you don't have, by any chance, links to the referenced CI runs which you could share here as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good to me 👍
@XComp Thanks a lot for the quick review. The CI is here https://github.com/apache/flink-shaded/actions/runs/6727989844. |
Sorry for not being that clear. I meant the ARM compilation error you mentioned in the PR description:
I was wondering whether there would be a link to the failure and a link to a run that succeeded with this fix being applied. |
ok. I have only the screenshots of the error, unfortunately, I do not have any links to provide. I have attached these screenshots to the Jira(https://issues.apache.org/jira/browse/FLINK-33417). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks @reswqa for verifying the PR as well. There's a discussion ongoing in FLINK-33417. I'm gonna wait with merging this change until the last questions are answered. |
Yes, make sense. |
I merged the PR after a final investigation. The results of the investigation are collected in FLINK-33417. Thanks for your patience @TanYuxin-tyx |
@XComp Thanks a lot for your investigation and the careful review. |
This is for https://issues.apache.org/jira/browse/FLINK-33417.
In our ARM environment, we encounter a compile error when using Flink 1.17.
Flink 1.17 depends on flink-shaded 16.1, which uses netty 4.1.82. However, flink-shaded 16.1 fails to compile in the ARM environment. As a result, we are unable to compile Flink 1.17 due to this issue.
We have tested compiling flink-shaded using netty 4.1.83 or a later version in ARM env, and it can compile successfully.
Taking into consideration the previous discussions regarding compatibility and the dependency of external connectors on this version, I propose addressing the bug by only updating flink-shaded's netty to a minor version (e.g., 4.1.83) rather than backporting FLINK-32032.
To implement the update, maybe a new release of flink-shaded 16.2 needs to be released.
The discussion details is at https://lists.apache.org/thread/y1c8545bcsx2836d9pgfdzj65knvw7kb.