Skip to content

Conversation

@githubMJ
Copy link

@githubMJ githubMJ commented Apr 22, 2021

What is the purpose of the change

Flink Table Parsr Hive Drop Partitions Syntax unparse is Error

Brief change log

Flink Table unpase is error:
Synopsis:
SQL:
alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);
hive muit partition unparse toSqlString is :

ALTER TABLE `TBL`\n" +
      "DROP\n" +
      "PARTITION (`P1` = 'a', `P2` = 1)\n" +
      "PARTITION (`P1` = 'b', `P2` = 2)

Missing comma in Partition SqlNodeList
Hive syntax:
ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [, PARTITION (partition_spec)];

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 22, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a739239 (Fri May 28 11:04:59 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@githubMJ githubMJ changed the title Flink Table Parsr Hive Drop Partitions Syntax unparse is Error [FLINK-22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is Error Apr 22, 2021
@githubMJ githubMJ closed this Apr 22, 2021
@githubMJ githubMJ reopened this Apr 22, 2021
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@githubMJ githubMJ closed this Apr 22, 2021
@githubMJ githubMJ reopened this Apr 22, 2021
@githubMJ githubMJ closed this Apr 22, 2021
@githubMJ githubMJ deleted the FLINK-22408 branch April 22, 2021 13:08
@githubMJ githubMJ restored the FLINK-22408 branch April 22, 2021 13:08
@githubMJ githubMJ deleted the FLINK-22408 branch April 22, 2021 13:10
@githubMJ githubMJ restored the FLINK-22408 branch April 22, 2021 13:16
@githubMJ githubMJ reopened this Apr 22, 2021
@githubMJ
Copy link
Author

@flinkbot run azure

@githubMJ
Copy link
Author

@flinkbot run azure

1 similar comment
@githubMJ
Copy link
Author

@flinkbot run azure

@githubMJ
Copy link
Author

close PR, fix this issue in release-1.12 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants