Skip to content

[FLINK-22559][table-planner] The consumed DataType of ExecSink should only consider physical columns #15864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leonardBang wants to merge 1 commit into from
Closed

[FLINK-22559][table-planner] The consumed DataType of ExecSink should only consider physical columns #15864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...c/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.flink.table.utils.LegacyRowResource;
import org.apache.flink.types.Row;

import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -198,7 +197,6 @@ public void testSourceSinkWithKeyAndPartialValue() throws Exception {
}

@Test
@Ignore // FLINK-22559
public void testKafkaSourceSinkWithKeyAndFullValue() throws Exception {
// we always use a different topic name for each parameterized topic,
// in order to make sure the topic can be created.
Expand Down
2 changes: 1 addition & 1 deletion ...k/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,6 @@ private InternalTypeInfo<RowData> getInputTypeInfo() {
}

private RowType getConsumedRowType(ResolvedSchema schema) {
return (RowType) schema.toSinkRowDataType().getLogicalType();
return (RowType) schema.toPhysicalRowDataType().getLogicalType();
}
}