Skip to content

[FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is… #15894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
githubMJ wants to merge 1 commit into from
Closed

[FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is… #15894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...arser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,16 @@ public void testDropPartition() {
.ok(
"ALTER TABLE `TBL`\n"
+ "DROP\n"
+ "PARTITION (`P1` = 'a', `P2` = 1)\n"
+ "PARTITION (`P1` = 'a', `P2` = 1),\n"
+ "PARTITION (`P1` = 'b', `P2` = 2)");
sql("alter table tbl drop partition (p1='a',p2=1), "
+ "partition(p1='b',p2=2), partition(p1='c',p2=3)")
.ok(
"ALTER TABLE `TBL`\n"
+ "DROP\n"
+ "PARTITION (`P1` = 'a', `P2` = 1),\n"
+ "PARTITION (`P1` = 'b', `P2` = 2),\n"
+ "PARTITION (`P1` = 'c', `P2` = 3)");
// TODO: support IGNORE PROTECTION, PURGE
}

Expand Down
3 changes: 3 additions & 0 deletions ...ble/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropPartitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,14 @@ public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
}
int opLeftPrec = getOperator().getLeftPrec();
int opRightPrec = getOperator().getRightPrec();
final SqlWriter.Frame frame = writer.startList("", "");
for (SqlNodeList partSpec : partSpecs) {
writer.sep(",");
writer.newlineAndIndent();
writer.keyword("PARTITION");
partSpec.unparse(writer, opLeftPrec, opRightPrec);
}
writer.endList(frame);
}

@Nonnull
Expand Down