Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,12 @@ public Expression[] accumulateExpressions() {

@Override
public Expression[] retractExpressions() {
// TODO FLINK-12295, ignore exception now
// throw new TableException("This function does not support retraction, Please choose
// MaxWithRetractAggFunction.");
// See optimization in FlinkRelMdModifiedMonotonicity.
// This function can ignore retraction message:
// SQL: SELECT MAX(cnt), SUM(cnt) FROM (SELECT count(a) as cnt FROM T GROUP BY b)
// The cnt is modified increasing, so the MAX(cnt) can ignore retraction message. But this
// doesn't mean that the node won't receive the retraction message, because there are other
// aggregate operators that need retraction message, such as SUM(cnt).
return new Expression[0];
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ public Expression[] accumulateExpressions() {

@Override
public Expression[] retractExpressions() {
// TODO FLINK-12295, ignore exception now
// throw new TableException("This function does not support retraction, Please choose
// MinWithRetractAggFunction.");
// See MaxAggFunction.retractExpressions
return new Expression[0];
}

Expand Down