-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery #23169
base: master
Are you sure you want to change the base?
Conversation
@mayuehappy thanks for the draft PR. General idea of the PR looks good to me, we should still polish it and avoid code duplication. I currently cannot test the PR because the frocksDB dependency is missing. How do you want to proceed with this? |
@pnowojski I think we might have two small problems to face:
|
Newer versions of RocksDB are backward compatible, compatibility will not be a hindrance. https://github.com/facebook/rocksdb/wiki/RocksDB-Overview#compatibility |
@mayuehappy I noticed that one required PR against RocksDB (facebook/rocksdb#11646) is still not merged and the conversation is stalling. Do you think it's ok to ping Adam to take another look? |
|
@StefanRRichter Thanks for the reminder, I've pinged him and cbi42 under the PR. |
@mayuehappy I think there is already a reply on the RocksDB PR. So if you think with their guidance it's now reasonable to assume this can be merged soon, then there is no need to merge early. But otherwise that would be an option to make progress on the Flink side. |
@flinkbot run azure |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation