Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37098] Fix selecting time attribute from a view #25952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-37098] Fix selecting time attribute from a view #25952

wants to merge 1 commit into from
+146 −92

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

It makes it possible to query views which have time attributes added while converting from SqlNode to RelNode

Verifying this change

Added a test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 10, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

davidradl
davidradl reviewed Jan 10, 2025
View reviewed changes
...table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java
return;
}
TableTestUtil testUtil = getTestUtil();
TableEnvironment tableEnvironment = testUtil.getTableEnv();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone in our team tested and the test works before the fix. Is there a test that would have failed before the fix and now passes after your fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask them to verify again, cause it does not pass without the changes here, if you have https://issues.apache.org/jira/browse/FLINK-36883 applied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawidwys Ah I see we were testing on 1.19. I will let him know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl left review comments

Assignees
No one assigned
Labels
component=TableSQL/Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawidwys @flinkbot @davidradl