-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37026] Add Stale PR GitHub Action workflow #25953
base: master
Are you sure you want to change the base?
Conversation
operationsPerRun: | ||
description: 'Max GitHub API operations' | ||
required: true | ||
default: 200 # Initially we set this at a high level to clear the backlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use variables at the top for all numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a variable, its referenced in the action.
Signed-off-by: Thomas Cooper <code@tomcooper.dev>
03ee68c
to
f7d4079
Compare
on: | ||
schedule: | ||
#- cron: '15 6 * * *' # Run once a day at 6:15 UTC | ||
- cron: '0 */6 * * *' # Initially we run every 6 hours until we have reached steady state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it doesn't matter but this could also just run once a day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it should, but in the CHI meetings we were keen to burn thought the backlog of stale PRs ASAP. Should only take a few days then we can switch it to daily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tomncooper for the contribution!
LGTM~
What is the purpose of the change
This is the implementation of the Stale PR GitHub Action Proposal. This was voted through on the dev mailing list.
The initial setting is for 6 months of inactivity to be marked as stale with 3 month to respond before the PR is closed. Ideally, once the initial backlog is cleared, we will reduces these down to 3 months and 1 month respectively, to match other Apache projects.
There is also configuration for when the action is run and how many PRs it will process in one run. Initially I have set this to every 6 hours and 200 PRs per run, this will allow us to process the backlog in a few days. After which these can be reduced to daily, with a lower request limit (e.g. 50).
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation