[FLINK-11486][tests] Port RecoveryITCase to new code base #7683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
force-pushed
the
FLINK-11486
branch
3 times, most recently
from
bf63261 to
a876d24
Compare
Clarkkkkk
reviewed
Feb 13, 2019
| */ | ||
| @Test | ||
| public void testNewTaskExecutorJoinsCluster() throws Exception { | ||
| public void testCleanClusterStateAfterTaskExecutorTermination() throws Exception { |
Contributor
There was a problem hiding this comment.
The name is not very intuitive, I think testJobReExecutionAfterTaskExecutorTermination would be better.
Contributor
Author
There was a problem hiding this comment.
Good idea. I will apply the changes.
tillrohrmann
force-pushed
the
FLINK-11486
branch
3 times, most recently
from
960e758 to
5f75aa8
Compare
GJL
reviewed
Feb 14, 2019
| CommonTestUtils.waitUntilCondition( | ||
| jobIsRunning(() -> miniCluster.getExecutionGraph(jobGraph.getJobID())), | ||
| Deadline.fromNow(TESTING_TIMEOUT), | ||
| 20L); |
Member
There was a problem hiding this comment.
There is a bug in waitUntilCondition which leads to 20 being ignored.
Contributor
Author
There was a problem hiding this comment.
Good catch. Will fix it while merging this PR.
GJL
approved these changes
Feb 14, 2019
Contributor
Author
|
Thanks for the review @GJL. I'll address your comment while merging this PR. |
…ception, Deadline, long) Properly pass the retryIntervalMillis to the sleep call.
- "recover a task manager failure" --> TaskExecutorITCase#testJobRecoveryWithFailingTaskExecutor - "recover once failing forward job" --> JobRecoveryITCase#testTaskFailureRecovery - "recover once failing forward job with slot sharing" --> JobRecoveryITCase#testTaskFailureWithSlotSharingRecovery
Increase the retry interval for TaskExecutorITCase and ZooKeeperLeaderElectionITCase since they take so long that the low retry interval won't have a big effect apart from a higher CPU load.
tillrohrmann
force-pushed
the
FLINK-11486
branch
from
5f75aa8 to
21fabef
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 14, 2019
- "recover a task manager failure" --> TaskExecutorITCase#testJobRecoveryWithFailingTaskExecutor - "recover once failing forward job" --> JobRecoveryITCase#testTaskFailureRecovery - "recover once failing forward job with slot sharing" --> JobRecoveryITCase#testTaskFailureWithSlotSharingRecovery This closes apache#7683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Port
RecoveryITCaseto new code base.This PR is based on #7676.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation