Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jul 1, 2019

If an execution finishes it doesn not issue release calls for partitions as they could be re-used later. If the corresponding vertex is reset however we still have to release the partitions that the (now old) execution produced.

This PR implements this behavior.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 1, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

final ResultPartitionID resultPartitionID = execution
.getResultPartitionDeploymentDescriptor(intermediateResultPartitionID)
.get()
.getShuffleDescriptor().getResultPartitionID();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe break the line between method calls for consistency


public ExecutionGraph build() throws JobException, JobExecutionException {
return ExecutionGraphBuilder.buildGraph(
priorExecutionGraph,
Copy link
Member

@GJL GJL Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to include priorExecutionGraph in the builder. I cannot find a usage of buildGraph() where prior is non-null.

@zentol zentol merged commit 6f6cfde into apache:master Jul 1, 2019
@zentol zentol deleted the 12997 branch July 2, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants