Skip to content

Conversation

@azagrebin
Copy link
Contributor

What is the purpose of the change

The simplest IT test is to create a batch job with a sequence of non-parallel mappers.
The each mapper writes to a blocking partition which means the next mapper starts when the previous is done.
The mappers are not chained into one Task which makes them separate failover regions.

Brief change log

add BatchFineGrainedRecoveryITCase

Verifying this change

run BatchFineGrainedRecoveryITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 3, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❗ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@azagrebin
Copy link
Contributor Author

@flinkbot attention @zentol

@zentol zentol self-assigned this Jul 3, 2019
@azagrebin azagrebin force-pushed the FLINK-13019 branch 2 times, most recently from 32645e1 to bb1815f Compare July 3, 2019 15:47
The simplest IT test is to create a batch job with a sequence of non-parallel mappers.
The each mapper writes to a blocking partition which means the next mapper starts when the previous is done.
The mappers are not chained into one Task which makes them separate failover regions.
@zentol zentol merged commit f333ea4 into apache:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants