Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous trivial fixes #275

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Miscellaneous trivial fixes #275

merged 1 commit into from
Aug 30, 2019

Conversation

ctubbsii
Copy link
Member

  • Add missing newlines at end of files
  • Remove trailing whitespace
  • Remove redundant Apache license headers
  • Make .gitignore files more specific
  • Add example pom.xml for contrib/add-license-headers.md
  • Format markdown files with syntax highlighting for code blocks
  • Format json files with jq
  • Add missing quotes for json templates
  • Add missing punctuation in READMEs (missing periods on sentences)

@ctubbsii
Copy link
Member Author

@keith-ratcliffe Perhaps you'd be interested in reviewing this? I've altered some of the doc/example files from your #274 in this.

@ctubbsii
Miscellaneous trivial fixes
0930020 
* Add missing newlines at end of files
* Remove trailing whitespace
* Remove redundant Apache license headers
* Make .gitignore files more specific
* Add example pom.xml for contrib/add-license-headers.md
* Format markdown files with syntax highlighting for code blocks
* Format json files with jq
* Add missing quotes for json templates
* Add missing punctuation in READMEs (missing periods on sentences)
* Add missing quotes in JSON in README
@ctubbsii
Copy link
Member Author

Rebased onto #276

SlickNik
SlickNik approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@SlickNik SlickNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@keith-ratcliffe
Copy link
Contributor

@keith-ratcliffe Perhaps you'd be interested in reviewing this? I've altered some of the doc/example files from your #274 in this.

Looks good

@ctubbsii ctubbsii merged commit 5ca9b8e into apache:master Aug 30, 2019
@ctubbsii ctubbsii deleted the misc-cleanup branch August 30, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlickNik SlickNik SlickNik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctubbsii @keith-ratcliffe @SlickNik