-
Notifications
You must be signed in to change notification settings - Fork 21
Add DEVELOPMENT.md #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+115
−0
Merged
Add DEVELOPMENT.md #155
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
|
|
||
| # Development Guide | ||
|
|
||
| Welcome to the development guide of `fluss-rust`! This project builds `fluss-rust` client and language specific bindings. | ||
|
|
||
| ## Pre-requisites | ||
|
|
||
| - protobuf | ||
| - rust | ||
|
|
||
| You can install these using your favourite package / version manager. Example installation using mise: | ||
|
|
||
| ```bash | ||
| mise install protobuf | ||
| mise install rust | ||
| ``` | ||
|
|
||
| ## IDE Setup | ||
|
|
||
| We recommend [RustRover](https://www.jetbrains.com/rust/) IDE to work with fluss-rust code base. | ||
|
|
||
| ### Importing fluss-rust | ||
|
|
||
| 1. On your terminal, clone fluss-rust project from GitHub | ||
| ```bash | ||
| git clone https://github.com/apache/fluss-rust.git | ||
| ``` | ||
| 1. Open RustRover, on `Projects` tab, click `Open` and navigate to the root directory of fluss-rust | ||
| 1. Click `Open` | ||
|
|
||
| ### Copyright Profile | ||
|
|
||
| Fluss and Fluss-rust are Apache projects and as such every files need to have Apache licence header. This can be automated in RustRover by adding a Copyright profile: | ||
|
|
||
| 1. Go to `Settings` -> `Editor` -> `Copyright` -> `Copyright Profiles`. | ||
| 1. Add a new profile and name it `Apache`. | ||
| 1. Add the following text as the license text: | ||
| ``` | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| ``` | ||
| 1. Go to `Editor` -> `Copyright` and choose the `Apache` profile as the default profile for this project. | ||
| 1. Click `Apply` | ||
|
|
||
| We also use line comment formatting for licence headers. | ||
| 1. Go to `Editor` -> `Copyright` -> `Formatting` -> `Rust` | ||
| 1. Choose `Use custom formatting` | ||
| 1. Choose `Use line comment` | ||
|
|
||
| ## Project directories | ||
|
|
||
| Source files are organized in the following manner | ||
|
|
||
| 1. `crates/fluss` - fluss rust client crate source | ||
| 1. `crates/examples` - fluss rust client examples | ||
| 1. `bindings` - bindings to other languages e.g. C++ under `bindings/cpp` and Python under `bindings/python` | ||
| 1. Click `Apply` | ||
| 2. | ||
| ## Building & Testing | ||
|
|
||
| See [quickstart](README.md#quick-start) for steps to run example code. | ||
|
|
||
| Running all unit tests for fluss rust client: | ||
|
|
||
| ```bash | ||
| cargo test --workspace | ||
| ``` | ||
|
|
||
leekeiabstraction marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Running all integration test cases: | ||
|
|
||
| ```bash | ||
| cargo test --features integration_tests --workspace | ||
| ``` | ||
|
|
||
|
|
||
| ### Formatting and Clippy | ||
|
|
||
| Our CI runs cargo formatting and clippy to help keep the code base styling tidy and readable. Run the following commands and address any errors or warnings to ensure that your PR can complete CI successfully. | ||
|
|
||
| ```bash | ||
| cargo fmt --all | ||
| cargo clippy --all-targets --fix --allow-dirty --allow-staged | ||
| ``` | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.